-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59610/#review176358
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
Line 137 (original), 137 (patched)
<https://reviews.apache.org/r/59610/#comment249748>

    This will make Numeric reserved keyword, which is ok, but we need to note 
that in Release Notes field of jira and mark incompatible change flag in jira.


- Ashutosh Chauhan


On May 26, 2017, 5:43 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59610/
> -----------------------------------------------------------
> 
> (Updated May 26, 2017, 5:43 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16764
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 393df65cd9 
>   ql/src/test/queries/clientpositive/perf/query1.q d40f66aa1d 
>   ql/src/test/queries/clientpositive/perf/query10.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query12.q 7ef6cb89eb 
>   ql/src/test/queries/clientpositive/perf/query13.q 6f43d4738f 
>   ql/src/test/queries/clientpositive/perf/query14.q e075f4f4a8 
>   ql/src/test/queries/clientpositive/perf/query15.q 9f75410fbe 
>   ql/src/test/queries/clientpositive/perf/query16.q 0243bf3fbe 
>   ql/src/test/queries/clientpositive/perf/query17.q bb8a33b8de 
>   ql/src/test/queries/clientpositive/perf/query18.q e6061f5579 
>   ql/src/test/queries/clientpositive/perf/query19.q cfb62185d0 
>   ql/src/test/queries/clientpositive/perf/query2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query20.q d4ea10dc18 
>   ql/src/test/queries/clientpositive/perf/query21.q 4c68df9a9e 
>   ql/src/test/queries/clientpositive/perf/query22.q adb509dab0 
>   ql/src/test/queries/clientpositive/perf/query23.q 4939416e73 
>   ql/src/test/queries/clientpositive/perf/query24.q b9b747f4ab 
>   ql/src/test/queries/clientpositive/perf/query25.q 80185ab00c 
>   ql/src/test/queries/clientpositive/perf/query26.q 0e81120214 
>   ql/src/test/queries/clientpositive/perf/query27.q 0cbb3ae5a9 
>   ql/src/test/queries/clientpositive/perf/query28.q 2a5f0922d4 
>   ql/src/test/queries/clientpositive/perf/query29.q 1634b1f6ae 
>   ql/src/test/queries/clientpositive/perf/query3.q 47dfac57c9 
>   ql/src/test/queries/clientpositive/perf/query30.q 25c9e07d11 
>   ql/src/test/queries/clientpositive/perf/query31.q d448dc3894 
>   ql/src/test/queries/clientpositive/perf/query32.q ceb2ddb03c 
>   ql/src/test/queries/clientpositive/perf/query33.q 06628bd1af 
>   ql/src/test/queries/clientpositive/perf/query34.q 5c3efe1719 
>   ql/src/test/queries/clientpositive/perf/query35.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query36.q 6c3a945a8f 
>   ql/src/test/queries/clientpositive/perf/query37.q c71ec56f8f 
>   ql/src/test/queries/clientpositive/perf/query38.q 2e8517e3b3 
>   ql/src/test/queries/clientpositive/perf/query39.q c9f8f2b96e 
>   ql/src/test/queries/clientpositive/perf/query40.q 155fa084c5 
>   ql/src/test/queries/clientpositive/perf/query42.q c4b115b236 
>   ql/src/test/queries/clientpositive/perf/query43.q f1c22e86d6 
>   ql/src/test/queries/clientpositive/perf/query44.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query45.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query46.q 3e8711f9a1 
>   ql/src/test/queries/clientpositive/perf/query48.q a02f6302ed 
>   ql/src/test/queries/clientpositive/perf/query49.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query5.q a877c4cd88 
>   ql/src/test/queries/clientpositive/perf/query50.q e4bdf0ab6f 
>   ql/src/test/queries/clientpositive/perf/query51.q b7688cfefc 
>   ql/src/test/queries/clientpositive/perf/query52.q 24d0ac3231 
>   ql/src/test/queries/clientpositive/perf/query53.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query54.q b1a3e832a8 
>   ql/src/test/queries/clientpositive/perf/query55.q 644ba1afd5 
>   ql/src/test/queries/clientpositive/perf/query56.q 63e53ea9fe 
>   ql/src/test/queries/clientpositive/perf/query58.q d392ded7d8 
>   ql/src/test/queries/clientpositive/perf/query59.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query6.q 8e4a7d375e 
>   ql/src/test/queries/clientpositive/perf/query60.q efa86d1079 
>   ql/src/test/queries/clientpositive/perf/query61.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query63.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query64.q 13ebf4ab76 
>   ql/src/test/queries/clientpositive/perf/query65.q bd4475d8ff 
>   ql/src/test/queries/clientpositive/perf/query66.q 9224680411 
>   ql/src/test/queries/clientpositive/perf/query67.q ca2fc61fb0 
>   ql/src/test/queries/clientpositive/perf/query68.q 34f87c2cdd 
>   ql/src/test/queries/clientpositive/perf/query69.q d9528ae18a 
>   ql/src/test/queries/clientpositive/perf/query7.q 39c4383a8c 
>   ql/src/test/queries/clientpositive/perf/query70.q 80f8c234d6 
>   ql/src/test/queries/clientpositive/perf/query71.q d0601d283e 
>   ql/src/test/queries/clientpositive/perf/query72.q 6c076d6afe 
>   ql/src/test/queries/clientpositive/perf/query73.q 95c4695eed 
>   ql/src/test/queries/clientpositive/perf/query75.q a815c9e0af 
>   ql/src/test/queries/clientpositive/perf/query76.q 1894cf4088 
>   ql/src/test/queries/clientpositive/perf/query77.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query78.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query79.q d1046022f1 
>   ql/src/test/queries/clientpositive/perf/query8.q bb77f55933 
>   ql/src/test/queries/clientpositive/perf/query80.q 53f9a3ca34 
>   ql/src/test/queries/clientpositive/perf/query81.q 77de348b35 
>   ql/src/test/queries/clientpositive/perf/query82.q cf882b8789 
>   ql/src/test/queries/clientpositive/perf/query83.q 0186e0333c 
>   ql/src/test/queries/clientpositive/perf/query84.q bcc2f4eff7 
>   ql/src/test/queries/clientpositive/perf/query85.q b1e2b6433c 
>   ql/src/test/queries/clientpositive/perf/query86.q 07a9ec508a 
>   ql/src/test/queries/clientpositive/perf/query87.q fe12ee3257 
>   ql/src/test/queries/clientpositive/perf/query88.q bb6ef6d9f2 
>   ql/src/test/queries/clientpositive/perf/query89.q a628c0e632 
>   ql/src/test/queries/clientpositive/perf/query9.q 77bffcadf6 
>   ql/src/test/queries/clientpositive/perf/query90.q 515da06b10 
>   ql/src/test/queries/clientpositive/perf/query91.q 9458c0c8c1 
>   ql/src/test/queries/clientpositive/perf/query92.q 625e99fcb3 
>   ql/src/test/queries/clientpositive/perf/query93.q b60b041ecd 
>   ql/src/test/queries/clientpositive/perf/query94.q f9f4bc1b7f 
>   ql/src/test/queries/clientpositive/perf/query95.q fbd2d47df0 
>   ql/src/test/queries/clientpositive/perf/query96.q 29265ed5d8 
>   ql/src/test/queries/clientpositive/perf/query97.q 4995309ebf 
>   ql/src/test/queries/clientpositive/perf/query98.q ec4b5533a0 
>   ql/src/test/queries/clientpositive/perf/query99.q PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query1.q.out 7c583e40a4 
>   ql/src/test/results/clientpositive/perf/query10.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query12.q.out fb6d1af8e4 
>   ql/src/test/results/clientpositive/perf/query13.q.out d67abe2747 
>   ql/src/test/results/clientpositive/perf/query14.q.out 58889c7992 
>   ql/src/test/results/clientpositive/perf/query15.q.out adec728799 
>   ql/src/test/results/clientpositive/perf/query16.q.out cf90c0c162 
>   ql/src/test/results/clientpositive/perf/query17.q.out 2f32a9fde6 
>   ql/src/test/results/clientpositive/perf/query18.q.out da35ca0214 
>   ql/src/test/results/clientpositive/perf/query19.q.out cebfc3af40 
>   ql/src/test/results/clientpositive/perf/query2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query20.q.out cff652f372 
>   ql/src/test/results/clientpositive/perf/query23.q.out 5794301b48 
>   ql/src/test/results/clientpositive/perf/query24.q.out 105871f732 
>   ql/src/test/results/clientpositive/perf/query25.q.out 2b1c064e09 
>   ql/src/test/results/clientpositive/perf/query26.q.out 1c94c401f2 
>   ql/src/test/results/clientpositive/perf/query28.q.out 78129cf68b 
>   ql/src/test/results/clientpositive/perf/query29.q.out ec303d3f12 
>   ql/src/test/results/clientpositive/perf/query3.q.out ba37c276f5 
>   ql/src/test/results/clientpositive/perf/query30.q.out abe92b5b80 
>   ql/src/test/results/clientpositive/perf/query31.q.out b4562441f6 
>   ql/src/test/results/clientpositive/perf/query32.q.out c9820b3b7d 
>   ql/src/test/results/clientpositive/perf/query33.q.out 00c021bbbf 
>   ql/src/test/results/clientpositive/perf/query34.q.out 51710bddb3 
>   ql/src/test/results/clientpositive/perf/query35.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query36.q.out b5110d9b0d 
>   ql/src/test/results/clientpositive/perf/query39.q.out 3e34c2716e 
>   ql/src/test/results/clientpositive/perf/query42.q.out 307ef98840 
>   ql/src/test/results/clientpositive/perf/query43.q.out 72712e8189 
>   ql/src/test/results/clientpositive/perf/query44.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query45.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query46.q.out 8c6e914387 
>   ql/src/test/results/clientpositive/perf/query48.q.out e377e3f511 
>   ql/src/test/results/clientpositive/perf/query49.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query50.q.out 47a00b0e51 
>   ql/src/test/results/clientpositive/perf/query51.q.out 2468c7718f 
>   ql/src/test/results/clientpositive/perf/query52.q.out 3d4b9e5a9d 
>   ql/src/test/results/clientpositive/perf/query53.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query54.q.out e1f513519f 
>   ql/src/test/results/clientpositive/perf/query55.q.out 7948b6dc98 
>   ql/src/test/results/clientpositive/perf/query56.q.out 9e710e0a36 
>   ql/src/test/results/clientpositive/perf/query58.q.out e73605a0b1 
>   ql/src/test/results/clientpositive/perf/query59.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query6.q.out 04bda70902 
>   ql/src/test/results/clientpositive/perf/query60.q.out bb05a424e8 
>   ql/src/test/results/clientpositive/perf/query61.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query62.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query63.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query64.q.out 0d2fc21621 
>   ql/src/test/results/clientpositive/perf/query65.q.out 17d80d03b6 
>   ql/src/test/results/clientpositive/perf/query66.q.out 19cd0fb362 
>   ql/src/test/results/clientpositive/perf/query68.q.out 84f701bdcf 
>   ql/src/test/results/clientpositive/perf/query69.q.out 7ee80a61e4 
>   ql/src/test/results/clientpositive/perf/query7.q.out af77d9a6d9 
>   ql/src/test/results/clientpositive/perf/query70.q.out d4b7731bfe 
>   ql/src/test/results/clientpositive/perf/query71.q.out 6d8562917a 
>   ql/src/test/results/clientpositive/perf/query73.q.out 9e1a39a375 
>   ql/src/test/results/clientpositive/perf/query75.q.out 55da3a2d9b 
>   ql/src/test/results/clientpositive/perf/query76.q.out 19243db563 
>   ql/src/test/results/clientpositive/perf/query77.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query78.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query79.q.out 49557453b8 
>   ql/src/test/results/clientpositive/perf/query81.q.out 3acee4d5a5 
>   ql/src/test/results/clientpositive/perf/query83.q.out f96306b1bd 
>   ql/src/test/results/clientpositive/perf/query84.q.out cf687292a4 
>   ql/src/test/results/clientpositive/perf/query85.q.out 82df27bef3 
>   ql/src/test/results/clientpositive/perf/query86.q.out bc862917cb 
>   ql/src/test/results/clientpositive/perf/query88.q.out f7af4ef855 
>   ql/src/test/results/clientpositive/perf/query89.q.out 27467bd3a7 
>   ql/src/test/results/clientpositive/perf/query9.q.out 4dded91452 
>   ql/src/test/results/clientpositive/perf/query90.q.out aae0aec657 
>   ql/src/test/results/clientpositive/perf/query91.q.out 0ee7e43f1b 
>   ql/src/test/results/clientpositive/perf/query92.q.out d3abc231ee 
>   ql/src/test/results/clientpositive/perf/query93.q.out f28ba412b4 
>   ql/src/test/results/clientpositive/perf/query94.q.out 836b16bf9f 
>   ql/src/test/results/clientpositive/perf/query95.q.out fa94d0842b 
>   ql/src/test/results/clientpositive/perf/query96.q.out a6c1f46287 
>   ql/src/test/results/clientpositive/perf/query97.q.out ef9a791e67 
>   ql/src/test/results/clientpositive/perf/query98.q.out 2894f7e607 
>   ql/src/test/results/clientpositive/perf/query99.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59610/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Reply via email to