-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60259/
-----------------------------------------------------------
Review request for hive, Sergey Shelukhin and Siddharth Seth.
Bugs: HIVE-16926
https://issues.apache.org/jira/browse/HIVE-16926
Repository: hive-git
Description
-------
Initial patch, restructured the LlapTaskUmbilicalExternalClient code a bit.
- Uses shared LLAP umbilical server rather than a new server per external client
- Retries rejected submissions (WorkSubmitter helper class)
- No more deferred cleanup (from HIVE-16652). One thing about this is that once
clients are closed/unregistered, communicator.stop() is called and it's removed
from the registered list of clients. So we might get a few warning messages
about untracked taskAttemptIds coming in during heartbeat() .. if this is
undesirable we might be able to leave them in the registeredClients list (but
ignore heartbeats to them as they are tagged as closed), and remove them using
the HeartbeatCheckTask once they get too old.
Diffs
-----
llap-client/src/java/org/apache/hadoop/hive/llap/LlapBaseRecordReader.java
7fff147
llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java
406bdda
llap-client/src/java/org/apache/hadoop/hive/llap/tezplugins/helpers/LlapTaskUmbilicalServer.java
403381d
llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java
eb93241
Diff: https://reviews.apache.org/r/60259/diff/1/
Testing
-------
Thanks,
Jason Dere
