> On 六月 28, 2017, 10:49 a.m., Barna Zsombor Klara wrote: > > Sorry for getting back this late and thank you for the updates. I don't > > want to be too nitpicky but I did have another comment about rewording a > > log line, sorry. > > As for testing, you do have jars on the classpath during testing. So for > > example you can be pretty sure that the junit jar will be on your classpath > > somewhere, and you could write tests against ClassUtil using the junit > > packages. > > > > But the patch LGTM. > > ZhangBing Lin wrote: > Thank you for your suggest,I will try to write a unit test case based on > your advice.
Resubmit a new patch,Patch add the following: 1.add two unit tests for ClassUtil and UDFResister 2.Adjust the custom function registration function to the end of the registration, to prevent the same name function to register when the system function can not be covered by abnormal 3.Fix the contents of the log - ZhangBing ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60355/#review179085 ----------------------------------------------------------- On 六月 29, 2017, 6:37 a.m., ZhangBing Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60355/ > ----------------------------------------------------------- > > (Updated 六月 29, 2017, 6:37 a.m.) > > > Review request for hive, cheng xu and Xuefu Zhang. > > > Bugs: HIVE-16929 > https://issues.apache.org/jira/browse/HIVE-16929 > > > Repository: hive-git > > > Description > ------- > > Add a configuration item "hive.aux.udf.package.name.list" in hive-site.xml, > which is a scan corresponding to the $HIVE_HOME/auxlib/ directory jar package > that contains the corresponding configuration package name under the class > registered as a constant function. > Such as, > <property> > <name>hive.aux.udf.package.name.list</name> > <value>com.sample.udf,com.test.udf</value> > </property> > Instructions: > 1, upload your jar file to $ HIVE_HOME/auxlib > 2, configure your UDF function corresponding to the package to the > following configuration parameters > <property> > <name>hive.aux.udf.package.name.list</name> > <value>com.sample.udf</value> > </property> > > 3, the configuration items need to be placed in the hive-site.xml file > 4, restart the Hive service to take effect > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8bdefdad6 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 9795f3ef98 > ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/util/UDFRegister.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/util/TestClassUtil.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/util/TestUDFRegister.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60355/diff/5/ > > > Testing > ------- > > > Thanks, > > ZhangBing Lin > >
