> On Aug. 3, 2017, 11:52 a.m., Peter Vary wrote:
> > beeline/src/java/org/apache/hive/beeline/Rows.java
> > Lines 164 (patched)
> > <https://reviews.apache.org/r/61380/diff/1/?file=1788407#file1788407line165>
> >
> >     Why not calling the same o.toString() as before?

I'm not sure where you would like to have the o.toString. Arrays don't have 
their toString overridden so a direct call would result in nonsensical output.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61380/#review182090
-----------------------------------------------------------


On Aug. 2, 2017, 3:56 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61380/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 3:56 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Peter Vary.
> 
> 
> Bugs: HIVE-14786
>     https://issues.apache.org/jira/browse/HIVE-14786
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14786: Beeline displays binary column data as string instead of byte 
> array
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 
> 3ebbc9af9ba1a99dfc1d0af63ba362bae5eb2df4 
>   beeline/src/java/org/apache/hive/beeline/Rows.java 
> 924b9519a64427936101a9dc4bbe1831719194e6 
>   beeline/src/main/resources/BeeLine.properties 
> 3b8e3e6e9c94d88e5b05b136012aaa0e605262f1 
>   beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java 
> f3f3d3a20cfd751b544636d86ad95e8ad7a2341d 
>   
> beeline/src/test/org/apache/hive/beeline/TestIncrementalRowsWithNormalization.java
>  68da841f850d2e97bf4b89071ec6d20ce8cf5d10 
>   beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java 
> c7d9f8095cf56df957ebe2f50ed033a09bd4e31b 
> 
> 
> Diff: https://reviews.apache.org/r/61380/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Reply via email to