----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61604/#review182926 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java Line 36 (original), 37-40 (patched) <https://reviews.apache.org/r/61604/#comment258884> Instead of storing and using prunerExpr in PrunedPartitionList, using tbl Name, db Name and pruner expr might be better. This way this pruned partition list can track its own key and callers need to not construct this key everytime they need to look in cache. ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java Lines 278 (patched) <https://reviews.apache.org/r/61604/#comment258888> I wonder if we can pass an indicator field with different values from logical compiler vs physical compiler which throws exception in strict (or test) mode for physical compiler call. That way we can make sure we can fail query if we are making 2nd call. - Ashutosh Chauhan On Aug. 12, 2017, 2:16 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61604/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2017, 2:16 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17265 > https://issues.apache.org/jira/browse/HIVE-17265 > > > Repository: hive-git > > > Description > ------- > > HIVE-17265 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java > 949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > 56c016311d8141071a60d2a431749e4856ffbb66 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > 1d49568c8cda2aa6c27568f023dc39ec20ab1949 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 66248654e8c0b7d242a089f5ac1a624dfb06598d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 6cb0559ea04abebb1da38e93c2162666cdf95af9 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > d6695ccbf2611551d2038582df7faa69efd4013f > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java > 565fbef0aa1a63c50679a4057cb23e8c0092bc7d > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > da2e1e2d8b06d04992763288709c423a4f048b4e > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > 3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 > > > Diff: https://reviews.apache.org/r/61604/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
