> On Sept. 7, 2017, 10:36 p.m., Jason Dere wrote: > > ql/src/test/queries/clientpositive/mapjoin_hint.q > > Lines 44 (patched) > > <https://reviews.apache.org/r/62150/diff/1-2/?file=1817048#file1817048line44> > > > > How does this confirm that it works with CBO - would this query with > > subquery fail to compile without CBO?
Yes it will. I borrowed it from the tests meant for subqeueries which are not supported by default optimizer of CBO. I verified it by running without CBO. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62150/#review184899 ----------------------------------------------------------- On Sept. 7, 2017, 9:19 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62150/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 9:19 p.m.) > > > Review request for hive, Gopal V and Jason Dere. > > > Bugs: HIVE-17475 > https://issues.apache.org/jira/browse/HIVE-17475 > > > Repository: hive-git > > > Description > ------- > > Disable mapjoin using hint. Added a test. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 663c95bb0b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > a2414f3fd3 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java adf7f84b65 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 6f379da1e3 > ql/src/test/queries/clientpositive/mapjoin_hint.q PRE-CREATION > ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/62150/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
