----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62152/ -----------------------------------------------------------
(Updated Sept. 8, 2017, 3 p.m.) Review request for hive and Peter Vary. Changes ------- Thanks for the review Peter! Bugs: HIVE-17317 https://issues.apache.org/jira/browse/HIVE-17317 Repository: hive-git Description ------- HIVE-17317: Make Dbcp configurable using hive properties in hive-site.xml Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/Constants.java 794b697dc005802a3403bd39499e13bcd8cb2f99 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf3f50ba64a28e63b58badcc2bce7738bf434245 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0db1bc059c0f6a36e721d441dbd466736d270eca metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java 34765b0b2f34698a3ba29751a65a108e4c997502 metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java 1eb792ce4503dfd82ce5660a39a5f33c1db86913 metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java 9b3d6d5d7078301254a4cff0a0d8e5de44d03bc3 metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 1887c052be1e535539cc5ba4c634fa28dfc22f9d metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java daea544c7126fad26f02e39a95ea0bc0e4847387 Diff: https://reviews.apache.org/r/62152/diff/2/ Changes: https://reviews.apache.org/r/62152/diff/1-2/ Testing ------- Thanks, Barna Zsombor Klara