----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62247/#review185210 -----------------------------------------------------------
Ship it! LGTM - Ratandeep Ratti On Sept. 12, 2017, 3:04 p.m., Anthony Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62247/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 3:04 p.m.) > > > Review request for hive, Carl Steinbach and Ratandeep Ratti. > > > Bugs: HIVE-17394 > https://issues.apache.org/jira/browse/HIVE-17394 > > > Repository: hive-git > > > Description > ------- > > Previously, when Avro found a nullable union in the reader schema, it would > regenerate the TypeInfo for the field for every record. This patch reuses the > same TypeInfo that only needs to be calculated once. > > In our testing, we found this improved count() queries by 2x. > > > Diffs > ----- > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > ecfe15f59dac04bda3f8f1275babebf736608a6b > > > Diff: https://reviews.apache.org/r/62247/diff/1/ > > > Testing > ------- > > `mvn clean package -DskipTests -Dmaven.javadoc.skip=true` succeeded. > > > Thanks, > > Anthony Hsu > >
