----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62392/#review185625 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 4166-4178 (original), 4166-4178 (patched) <https://reviews.apache.org/r/62392/#comment261928> May want to get rid of this comment now. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Line 10727 (original), 10733 (patched) <https://reviews.apache.org/r/62392/#comment261931> better to use protected. ql/src/test/results/clientpositive/decimal_precision2.q.out Line 40 (original), 40 (patched) <https://reviews.apache.org/r/62392/#comment261932> This doesn't look correct. query had BD qualifier so this should be decimal. - Ashutosh Chauhan On Sept. 18, 2017, 9:40 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62392/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 9:40 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17535 > https://issues.apache.org/jira/browse/HIVE-17535 > > > Repository: hive-git > > > Description > ------- > > This patch provide CBO support for queries with no source e.g. select 1. This > patch updates the code to bypass metadata calls for dummy table, which is > used for queries with no source. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties d472bb3f9e > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 2645fab4c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > db29e3aa5d > ql/src/test/queries/clientnegative/subquery_missing_from.q 3b49ac6a0a > ql/src/test/queries/clientnegative/subquery_select_no_source.q 75cae51e6a > ql/src/test/results/clientnegative/subquery_missing_from.q.out b09a8e311f > ql/src/test/results/clientnegative/subquery_select_no_source.q.out > 37c4e57813 > ql/src/test/results/clientpositive/beeline/mapjoin2.q.out 08e398ad50 > ql/src/test/results/clientpositive/beeline/select_dummy_source.q.out > b6fa03f808 > ql/src/test/results/clientpositive/decimal_precision2.q.out 384ba80a58 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out 03ebe375b8 > ql/src/test/results/clientpositive/llap/mapjoin2.q.out cdee70b065 > ql/src/test/results/clientpositive/llap/select_dummy_source.q.out > 7efd2ff685 > ql/src/test/results/clientpositive/mapjoin2.q.out 08e398ad50 > ql/src/test/results/clientpositive/select_dummy_source.q.out b6fa03f808 > ql/src/test/results/clientpositive/timestamptz_1.q.out 475603357c > ql/src/test/results/clientpositive/udtf_stack.q.out 97dcd3a1cd > ql/src/test/results/clientpositive/vector_tablesample_rows.q.out 283762a3eb > > > Diff: https://reviews.apache.org/r/62392/diff/1/ > > > Testing > ------- > > Updated existing tests > > > Thanks, > > Vineet Garg > >
