----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62360/#review185773 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java Lines 80 (patched) <https://reviews.apache.org/r/62360/#comment262123> Since we are taking in a list of Paths to copy over and if one of path leads to FileNotFoundException, i am not sure if distcp guarantees that it will copy all other valid paths, hence we can be in a situation where we will miss copying some files as we might have given a list of 100 files and distcp for ex copies 10 files simultaneously and on 25 th file there is file not found, in this case the other 75 files might not be copied since we only check the checksum on the source. - anishek On Sept. 19, 2017, 8:06 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62360/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2017, 8:06 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > See HIVE-16898 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java > 88d6a7a > ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 54746d3 > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java 28e7bcb > > > Diff: https://reviews.apache.org/r/62360/diff/5/ > > > Testing > ------- > > Manually test it with debugger: setup a breakpoint right before copy, and > drop table in another session. > > > Thanks, > > Daniel Dai > >
