-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62776/#review187590
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
Lines 465 (patched)
<https://reviews.apache.org/r/62776/#comment264609>

    May remove this.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
Lines 466 (patched)
<https://reviews.apache.org/r/62776/#comment264610>

    Can you add comments for need of this map.


- Ashutosh Chauhan


On Oct. 4, 2017, 6:04 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62776/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2017, 6:04 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Teddy Choi.
> 
> 
> Bugs: HIVE-16511
>     https://issues.apache.org/jira/browse/HIVE-16511
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch fixes an issue with CBO where after generating logical plan null 
> constants will lose it's cast operator.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 038487f134 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
> fcebb6fbce 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  165f8c4317 
>   ql/src/test/results/clientpositive/llap/vector_coalesce.q.out d6865dd0ad 
>   
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out
>  ddc1d7be7b 
>   ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 
> b63d1e4527 
>   ql/src/test/results/clientpositive/min_structvalue.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/spark/query36.q.out c072728803 
>   ql/src/test/results/clientpositive/perf/spark/query70.q.out 716665bd4f 
>   ql/src/test/results/clientpositive/perf/spark/query86.q.out c5b25e8467 
>   ql/src/test/results/clientpositive/perf/tez/query36.q.out dee62b58f1 
>   ql/src/test/results/clientpositive/perf/tez/query70.q.out d700d60345 
>   ql/src/test/results/clientpositive/perf/tez/query86.q.out 6b59dd254f 
>   ql/src/test/results/clientpositive/vector_coalesce.q.out 445a246cb6 
> 
> 
> Diff: https://reviews.apache.org/r/62776/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

Reply via email to