----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/#review188672 -----------------------------------------------------------
Thanks for the patch Adam! Mostly looks good to me. Only some minor comments. testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/YetusPhase.java Lines 72-85 (patched) <https://reviews.apache.org/r/63144/#comment265692> nit: Is it possible to write this "nicer" :) It took me a while to understand this. Which parameter went where, which are the actual shell commands. Maybe one of the templates we used in ptest? Any idea is welcome :) testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/YetusPhase.java Lines 94 (patched) <https://reviews.apache.org/r/63144/#comment265691> It might be a good idea to print out the stack trace too - Peter Vary On Oct. 19, 2017, 12:40 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63144/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 12:40 p.m.) > > > Review request for hive, Peter Vary and Barna Zsombor Klara. > > > Bugs: HIVE-16748 > https://issues.apache.org/jira/browse/HIVE-16748 > > > Repository: hive-git > > > Description > ------- > > We already have Yetus check script ready for run in dev-support. We should > integrate this with the automated ptest infrastructure so that during > Precommit test we get a Yetus result back as Jira comment > > > Diffs > ----- > > dev-support/hive-personality.sh f3247aac6284b8dd863691b4819a10c3a896d50c > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 65a8216f6a076b0ee7baee11ca557f5e9f746316 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/YetusPhase.java > PRE-CREATION > testutils/ptest2/src/main/resources/source-prep.vm > 7ad50248af02dfaeb6524a61d4895f1a8efba211 > > > Diff: https://reviews.apache.org/r/63144/diff/1/ > > > Testing > ------- > > Tested on Cloudera sponsored sandbox ptest server. > > > Thanks, > > Adam Szita > >
