> On Oct. 30, 2017, 10:12 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Line 315 (original), 326 (patched) > > <https://reviews.apache.org/r/63381/diff/1/?file=1870643#file1870643line332> > > > > why does this only close pool sessions? the old behavior is to close > > all of them
No longer required. > On Oct. 30, 2017, 10:12 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Lines 431 (patched) > > <https://reviews.apache.org/r/63381/diff/1/?file=1870643#file1870643line437> > > > > hmm... why is this assumed to be a non-pool session? I think canWork... > > may return true for pool sessions, in fact I'd expect it to be a common > > path where user doesn;t have any special configs or queue requests. > > > > IIRC this might be the reuse use case. No longer required. > On Oct. 30, 2017, 10:12 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java > > Lines 168 (patched) > > <https://reviews.apache.org/r/63381/diff/1/?file=1870644#file1870644line168> > > > > hmm... where is this conf coming from? is it possible to initialize it > > with the main conf when HS2 is being initialized, since it only applies in > > HS2? This looks like it may initialize with some random user task conf and > > also may not be threadsafe Updated to use session conf. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63381/#review189651 ----------------------------------------------------------- On Oct. 30, 2017, 11:25 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63381/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 11:25 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-17926 > https://issues.apache.org/jira/browse/HIVE-17926 > > > Repository: hive-git > > > Description > ------- > > HIVE-17926: Support triggers for non-pool sessions > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersNoTezSessionPool.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java b67c933 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 9b4714f > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb > > > Diff: https://reviews.apache.org/r/63381/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
