> On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > hbase-handler/pom.xml > > Line 82 (original), 82 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872068#file1872068line82> > > > > scope=test?
Actually the code does have a reference to it. Not only for test. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java > > Lines 46 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872069#file1872069line46> > > > > Might be a good idea to extend DefaultHiveMetaHook to take advantage of > > other extension points. I'm not very faimilar with the implementation for insert operation. So I will delay that to later jira. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java > > Lines 57 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872069#file1872069line57> > > > > Any reason to not do this in this patch? Actually they are closed. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java > > Line 742 (original), 742 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872083#file1872083line742> > > > > Do we need to retain this for 0.23? That support is long gone :) I will leave this cleanup for later jira since seems other places also have 0.23 support. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/hbase/SkeletonHBaseTest.java > > Lines 106 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872088#file1872088line107> > > > > Is this test only or on cluster also we need to set up this property? This is needed for the cluster as well so habase will pick up right native lib. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > pom.xml > > Line 841 (original), 907 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872104#file1872104line907> > > > > I don't think we need to depend on hbase-sever. If this is only for > > unit tests, shall we add <scope>test</scope> Actually we need for the production code. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > serde/pom.xml > > Line 155 (original), 161 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872108#file1872108line161> > > > > Do we need this as well? Proabably not. It's actually needed. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > shims/0.23/pom.xml > > Line 67 (original), 73 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872109#file1872109line73> > > > > This shall not be needed. This is needed for getMiniDfs() call. > On Oct. 30, 2017, 4:28 p.m., Ashutosh Chauhan wrote: > > standalone-metastore/pom.xml > > Line 179 (original), 179 (patched) > > <https://reviews.apache.org/r/63394/diff/1/?file=1872114#file1872114line179> > > > > Probably not needed. It's actually needed. - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63394/#review189595 ----------------------------------------------------------- On Oct. 28, 2017, 11:54 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63394/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2017, 11:54 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-15016: Run tests with Hadoop 3.0.0-beta1 > > > Diffs > ----- > > common/pom.xml 868e14dbc321be1e4008ba1575568bbc81032791 > hbase-handler/pom.xml 7f57b771686aeb09d4d58a4ae591110c10260519 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java > PRE-CREATION > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java > c6f3b0ff3abfd78bb4139eb471beeb0b66211f2a > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 9cad97ad4b1a2654b8865d10645963cbe69eaa33 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java > 6054d533f00d4a8ffe4a3649486d0dfe1e19ae68 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 1ef454572c258983337a63a27415de990d56aa6f > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java > 4b8f62c913bf5ec0b1ee2cb7408c3da1d0785777 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java > a25a96faa99ee751fc8a25cce2e1a0af67e015c4 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java > b35aea9f60524640cd546d15cd88bacc28ceb36b > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseSerDe.java > f244ed656271c4db2f742bea6334d8ab1fd5bb89 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java > b2bdd19964b041d4a6fe0f75d8836663e106e34d > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestPutResultWritable.java > 561b0a8952448fc40ee5d4e9a9ab040d95370cf3 > hbase-handler/src/test/queries/positive/hbase_bulk.q > 475aafc1ce00f394481a7c10e2c3adc93341225c > hbase-handler/src/test/queries/positive/hbase_handler_bulk.q > 85581ecdacb3e0541c21634b509cf60001797262 > hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out > 1f42567a4b269a62138c5428e31e2ee112444295 > hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java > 4ace16ca6f24cf2d28846057ddba3a3877ab021b > > hcatalog/webhcat/svr/src/test/java/org/apache/hive/hcatalog/templeton/TestWebHCatE2e.java > 22d2cc6bff5ede76e492efcaca1a28c77e1cd539 > > hcatalog/webhcat/svr/src/test/java/org/apache/hive/hcatalog/templeton/mock/MockUriInfo.java > d69a7339c106182fc5f51d96aea0f925931c4c04 > itests/hcatalog-unit/pom.xml bb6b10554fa768f1d50fdcae15fc1a0f93f37c64 > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/hbase/ManyMiniCluster.java > 745aa999f92d2f2c56d444f990482697e9f960f1 > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/hbase/SkeletonHBaseTest.java > 4e1384a634b21cac4cf754fca4b09b446b9e82bf > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/hbase/TestPigHBaseStorageHandler.java > f8f18b3514e96eaea57ac924b2d3f5c0b95c154c > itests/hive-minikdc/pom.xml 95d2614901a247203487e9082b71c881efc1098d > itests/hive-unit-hadoop2/pom.xml 339a194f2dfd6ad9765e225b26d72cdc929d5687 > itests/hive-unit/pom.xml 14409832c80f5fcb5d633d9e0f283f40f33e35d4 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java > 707bcd10b759ea3783397495a19c99422b0f33fa > itests/qtest-accumulo/pom.xml 40d0a749c8406bacb66b92ffc063a4bf781143f2 > itests/qtest-spark/pom.xml a506f7f081f80f9c3e632d4b80d434b6c71f8c57 > itests/qtest/pom.xml 02664f3792e1512cc3f051089fbebc73a4ed39bc > itests/util/pom.xml e6dc09fb8f4bcc0408e2d4a1694661f2f7f13bef > itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java > 0cc9a890850f7a2652a001f33161d0de5a03bfa2 > itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java > 4f8fa05925ac26e78817ba1aa0957db19b53ccd5 > llap-server/pom.xml 47a04cc31018689c71c39ea48b392406df767c66 > > llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java > 6b08da66b64e245a9a3679a934a7a22aff99b37b > metastore/pom.xml 04c6f47879a4736f7b73199f61709140ad1b8dfd > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 0e24ba70b6c60cfb5f6eb8ff705f01f69c7a8f5e > pom.xml 006e8f8611f4f866ef0e55a61930b6165263b677 > ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out > b582471afd19680efd23f1a318e5d430d47593ed > ql/src/test/results/clientnegative/external1.q.out > 661d669206aa58522ef2efeaaa48ce275745a9d3 > ql/src/test/results/clientnegative/external2.q.out > eb5518c017160507bd5584ba62558a348d3230f3 > serde/pom.xml 7419cfb17ae4f52edb36e90ff3ef96e43a0072e1 > shims/0.23/pom.xml 3ff1d38776ddf1b14dcf9aeb695d7316c39119fd > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java > e9445eb11dd74f24167f1e156c824e5d688fdd87 > shims/common/src/main/java/org/apache/hadoop/fs/ProxyFileSystem.java > 2c37a51cf41fc78a9d1226d8ef09aa010cf799f1 > shims/scheduler/pom.xml 0eadb69435f5b8ad3a933d4f83954a844355e18e > spark-client/pom.xml 784d908e4a33077bf529e71a6b695ba43abbf827 > standalone-metastore/pom.xml 8df622f1796aab885e486b0abc1f00088aca1626 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java > c10e36f94a5e94c760ba0472777cb62333519369 > testutils/ptest2/src/main/resources/batch-exec.vm > 2d16ca3e8a06a1a4e7e515dccf657b31304d8559 > > > Diff: https://reviews.apache.org/r/63394/diff/1/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
