----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63490/#review190065 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java Lines 742 (patched) <https://reviews.apache.org/r/63490/#comment267318> Should this be applied synchronously? so that user/admin can know if the RP changes/alter command finished successfully or not. In case of failure, error can also be printed to console with msg saying how to rectify. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java Line 168 (original) <https://reviews.apache.org/r/63490/#comment267319> nit: unwanted import reorder. will conflict with multiple IDE ordering. - Prasanth_J On Nov. 3, 2017, 8:52 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63490/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 8:52 p.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira; please ignore revision 3, due to some glitch in RB generated code > got posted. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 5a627ce6bc > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java > 0ec7e85f5c > metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 > metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 > metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 > metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 > metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 > metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 > metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 > metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b > metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql > 5c770e2659 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8a55305647 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > dfb0a6d6aa > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 5aa20c582b > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 610b9fafd5 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 84b70d88b0 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > 96dc7d3c98 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > b0c6d583f0 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 70656feea7 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 6a2ff75c84 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java > f0658a665e > ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 8152cfeb59 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 94f42ddae0 > ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e > service/src/java/org/apache/hive/service/server/HiveServer2.java 2c4fe7fc2b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 62801c5385 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > a99b8e123e > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > e13dcd20a3 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java > c7cd983709 > standalone-metastore/src/main/resources/package.jdo 296e273ec8 > standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 > > > Diff: https://reviews.apache.org/r/63490/diff/4/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
