> On Nov. 6, 2017, 6:51 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 263-264 (original), 275-278 (patched) > > <https://reviews.apache.org/r/63528/diff/1/?file=1879637#file1879637line275> > > > > Shouldn't the partValues contain only the values from partBatch here?
Good catch, thanks! - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63528/#review190193 ----------------------------------------------------------- On Nov. 7, 2017, 10:22 a.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63528/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 10:22 a.m.) > > > Review request for hive, Peter Vary and Barna Zsombor Klara. > > > Bugs: HIVE-17969 > https://issues.apache.org/jira/browse/HIVE-17969 > > > Repository: hive-git > > > Description > ------- > > Refactoring alter table code to use batching of partitions when calling the > heavy removeUnusedColumnDescriptor method > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > ccadac1ada6aaae884ab39f5d99e91b8c542404e > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 7334a0c9fa87b1fe5b4f6c9d2073a477bc0f11ad > > > Diff: https://reviews.apache.org/r/63528/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
