[ 
https://issues.apache.org/jira/browse/HIVE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163691#comment-13163691
 ] 

jirapos...@reviews.apache.org commented on HIVE-2617:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3026/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Insert Overwrite table db.tname fails if partition already exists.
 For example-
 insert overwrite table db.tname PARTITION(part='p') select .. from t2 where 
part='p'; fails if partition 'p' already exists. 

Internal of the code not consider the database name of the table and it is 
continued with the default database.

Changed the code like if table contains the database name called the alter 
partition using the dbname and tablename.


This addresses bug HIVE-2617.
    https://issues.apache.org/jira/browse/HIVE-2617


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1210917 
  trunk/ql/src/test/queries/clientpositive/insert2_overwrite_partitions.q 
PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert2_overwrite_partitions.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/3026/diff


Testing
-------

Added new testcase and all unit tests are passed


Thanks,

chinna


                
> Insert overwrite table db.tname fails if partition already exists 
> ------------------------------------------------------------------
>
>                 Key: HIVE-2617
>                 URL: https://issues.apache.org/jira/browse/HIVE-2617
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Aniket Mokashi
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2617.patch
>
>
> Insert Overwrite table db.tname fails if partition already exists.
> For example-
> insert overwrite table db.tname PARTITION(part='p') select .. from t2 where 
> part='p'; fails if partition 'p' already exists. Workaround is - use db; and 
> the fire the command.
> From the source code-
> alterPartition(tbl.getTableName(), new Partition(tbl, tpart)); takes String 
> tablename as argument and loses db information. Table table = 
> newTable(tablename) is called to retrieve table from name. But, it relies on 
> currentDatabase value (hence the workaround).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to