> On Nov. 15, 2017, 8:44 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/results/clientpositive/llap/sysdb.q.out > > Lines 2236 (patched) > > <https://reviews.apache.org/r/63711/diff/6/?file=1892471#file1892471line2236> > > > > not sure why this file is changing. Do you know? > > cheng xu wrote: > Actually this test case is failing in pre-commit due to difference in > output. Locally I am not able to reproduce the output as the golden files. So > I prefer to upload the local version instead and file other jira about this > failing test case. Any thoughts on that?
Yes, I think we should exclude the changes to this file since it is not related to the patch. Lets fix it a separate JIRA. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63711/#review191092 ----------------------------------------------------------- On Nov. 15, 2017, 1:34 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63711/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 1:34 a.m.) > > > Review request for hive and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > Most of the vectorization related q-tests operate on ORC tables using Tez. It > would be good to add more coverage on a different combination of engine and > file-format. We can model existing q-tests using parquet tables and run it > using TestSparkCliDriver > > > Diffs > ----- > > data/scripts/q_test_cleanup.sql 4620dcd > data/scripts/q_test_init.sql f763c12 > itests/src/test/resources/testconfiguration.properties 1d16b65 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f1d90ff > pom.xml dfb29ce > ql/src/test/queries/clientpositive/parquet_read_backward_compatible_files.q > 0abbc2f > ql/src/test/queries/clientpositive/parquet_vectorization_0.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_1.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_10.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_11.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_12.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_13.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_14.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_15.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_16.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_17.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_2.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_3.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_4.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_5.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_6.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_7.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_8.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_9.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_decimal_date.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_div0.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_limit.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_nested_udf.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_not.q PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_offset_limit.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_part.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_part_project.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_part_varchar.q > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_vectorization_pushdown.q > PRE-CREATION > ql/src/test/results/clientpositive/add_part_exist.q.out f8d50ca > ql/src/test/results/clientpositive/alter1.q.out c2efbe5 > ql/src/test/results/clientpositive/alter2.q.out 18032ac > ql/src/test/results/clientpositive/alter3.q.out 3bd7288 > ql/src/test/results/clientpositive/alter4.q.out ddcb0ed > ql/src/test/results/clientpositive/alter5.q.out 1eb24c2 > ql/src/test/results/clientpositive/alter_index.q.out bca4e12 > ql/src/test/results/clientpositive/alter_rename_partition.q.out 5702d39 > ql/src/test/results/clientpositive/authorization_9.q.out 39e0a56 > ql/src/test/results/clientpositive/authorization_show_grant.q.out d0fed81 > ql/src/test/results/clientpositive/cte_5.q.out ac0dac0 > ql/src/test/results/clientpositive/cte_mat_4.q.out bc92f14 > ql/src/test/results/clientpositive/cte_mat_5.q.out 3747cec > ql/src/test/results/clientpositive/describe_table_json.q.out ebf15ac > ql/src/test/results/clientpositive/drop_table_with_index.q.out 3175cdb > ql/src/test/results/clientpositive/index_creation.q.out ca113ef > ql/src/test/results/clientpositive/input2.q.out 4dac88a > ql/src/test/results/clientpositive/input3.q.out 8316a46 > ql/src/test/results/clientpositive/llap/cte_5.q.out dad6cd8 > ql/src/test/results/clientpositive/llap/cte_mat_4.q.out 67910c5 > ql/src/test/results/clientpositive/llap/cte_mat_5.q.out 92d8601 > ql/src/test/results/clientpositive/llap/jdbc_handler.q.out 6e0451f > ql/src/test/results/clientpositive/llap/resourceplan.q.out 5b5d8f1 > ql/src/test/results/clientpositive/llap/sysdb.q.out 9813636 > ql/src/test/results/clientpositive/llap/temp_table.q.out 4cf47b5 > > ql/src/test/results/clientpositive/parquet_read_backward_compatible_files.q.out > 22a050a > ql/src/test/results/clientpositive/parquet_vectorization_0.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_10.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_11.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_12.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_13.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_14.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_15.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_16.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_17.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_3.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_4.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_5.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_6.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_7.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_8.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_9.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_limit.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_nested_udf.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_not.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_offset_limit.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_part.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_part_project.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_part_varchar.q.out > PRE-CREATION > ql/src/test/results/clientpositive/parquet_vectorization_pushdown.q.out > PRE-CREATION > ql/src/test/results/clientpositive/rename_column.q.out 6ea13f8 > ql/src/test/results/clientpositive/show_tables.q.out 4c46c09 > ql/src/test/results/clientpositive/spark/parquet_vectorization_0.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_10.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_11.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_12.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_13.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_15.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_16.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_3.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_5.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_8.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_9.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_decimal_date.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_limit.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_nested_udf.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_not.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_offset_limit.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parquet_vectorization_part.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_part_project.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_part_varchar.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/parquet_vectorization_pushdown.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/temp_table.q.out 342d08c > ql/src/test/results/clientpositive/temp_table_truncate.q.out b1af432 > > > Diff: https://reviews.apache.org/r/63711/diff/6/ > > > Testing > ------- > > Qtest Added locally passed. > > > Thanks, > > cheng xu > >
