Andrew Sherman created HIVE-18127: ------------------------------------- Summary: Do not strip '--' comments from shell commands issued from CliDriver Key: HIVE-18127 URL: https://issues.apache.org/jira/browse/HIVE-18127 Project: Hive Issue Type: Bug Reporter: Andrew Sherman Assignee: Andrew Sherman
CLiDriver has the ability to run shell commands by prefixing them with '!". This behavior is not widely used (there are only 3 examples in .q files). Since HIVE-16935 started stripping comments starting with '\-\-', a shell command containing '--' will not work correctly. Fix this by using the unstripped command for shell commands. Note that it would be a security hole for HS2 to allow execution of arbitrary shell commands from a client command. Add tests to nail down correct behavior with '--' comments: * CliDriver should not strip strings starting with '--' in a shell command (FIXED in this change). * HiveCli should strip '--' comments. * A Jdbc program should allow commands starting with "!" but these will fail in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)