Removing this break our backwards compatibility. This interface provides public methods like getName. Hive may not be using them but we have no idea if others are in the wild. Given that including this has little or no cost to us AFAIK, why remove it?
Alan. On Mon, Nov 27, 2017 at 5:21 PM, Alexander Kolbasov <ak...@cloudera.com> wrote: > The hive_metastore.thrift has a dependency on fb303.FacebookService - the > ThriftHiveMetastore extends it. It looks like the only thing that it is > actually using is the shutdown() method. > > As an experiment I removed the dependency and the call to shutdown() method > and everything seems to compile just fine (I have not run any actual tests > yet). > > Does anyone think that FacebookService provides anything useful or it is > just an lod cruft that should be removed? > > - Alex >
