----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64282/#review193025 -----------------------------------------------------------
ql/src/test/queries/clientpositive/subquery_in.q Line 305 (original), 305-313 (patched) <https://reviews.apache.org/r/64282/#comment271519> Can you please add these queries in a new q file for MiniLlapDriver only. Current q.out is very large and its hard to understand impact of this patch on existing tests because of large diff size. ql/src/test/results/clientpositive/llap/subquery_in.q.out Lines 1029-1034 (original) <https://reviews.apache.org/r/64282/#comment271518> This query is now returning empty result set. Looks incorrect. - Ashutosh Chauhan On Dec. 6, 2017, 6:30 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64282/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 6:30 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18173 > https://issues.apache.org/jira/browse/HIVE-18173 > > > Repository: hive-git > > > Description > ------- > > Improve plans for correlated subqueries with non-equi predicate > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java > d1fe49c875 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606 > ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca > ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e > ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f > ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34 > ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0 > ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out > 6a4bea1bd4 > ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9 > ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca > ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a > ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60 > ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526 > ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965 > ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd > ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47 > ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec > > > Diff: https://reviews.apache.org/r/64282/diff/4/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
