-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64712/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Alan Gates, and Vineet Garg.
Bugs: HIVE-18224
https://issues.apache.org/jira/browse/HIVE-18224
Repository: hive-git
Description
-------
* introduces an interface to be used outside of ql
* changes usage of `Driver` outside of ql to be only thru `DriverFactory`
* doesn't change existing behaviour
* `HCatDriver` not anymore extends `Driver`
* the "bulk" change is to use the `Factory` outside of ql
The interface should be probably refined later; and remove some of the
confusing methods
Diffs
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
bd0b4229ce3e19976ff9b5c1a7001b7dd2fa526d
cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
8f1c15ea4992e75badf4433a1dccefe50f8dec78
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatDriver.java
48735959b06096bee023dc4c2373dee4a6c00e51
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java
d249d4340eb7d8b3db4160c32724e159ceb5e968
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestUseDatabase.java
1606982574a739bd066849777e667c22ff08ee83
hcatalog/core/src/test/java/org/apache/hive/hcatalog/data/HCatDataCheckUtil.java
ff56234cc1ad81ed260822c382aff2a630b46fa6
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/HCatBaseTest.java
f78eb15622f4ca2a79b8dfbbf4d06a3a2ddcca3e
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java
31857bf643b573b8a878f0fc1e353b07544fcf49
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java
59d2efb15669d49196b1c21e458eb5b98b3b8425
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java
4a6c6a3a6f61ee3c6f13298cf5a89522a9ab9260
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java
ea9cdda31cb092edf1bc7d2fd4c4b1f45906e3f6
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java
496f3c85da0eb23a48c75d54252e16eb14302c31
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java
40ea923858690cf4bd7f10896bb1083fd6e3b0ea
hcatalog/server-extensions/src/test/java/org/apache/hive/hcatalog/listener/TestMsgBusConnection.java
9f7c2072149caa50f5bb3d5a507ac302ab5d9095
hcatalog/server-extensions/src/test/java/org/apache/hive/hcatalog/listener/TestNotificationListener.java
3a334030bf6933861b9acf3288706603982de354
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
db3109e069bec6dcd43ab1c48f1bb76130ef7ad2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
dc8eee1aac3c3ff29574266485b4094a703322a4
hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/repl/commands/TestCommands.java
b9593218aee16bd142e536667dde15a227634ea6
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/hbase/TestPigHBaseStorageHandler.java
120b4af8264e65b48d8247a332266e25d8a091a1
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
308ab0d36aa0ac1550c91593bd1310587adcd13d
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/mapreduce/TestSequenceFileReadWrite.java
d2dbe8f287afefefbde804180a398591d2a2c09c
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
91fc706d5122f594524ced8b4bbfe4864989dcc2
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartition.java
7cf351fb35da56eda950c55bca84232e9447492b
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
e7b899b8d1cf7c383d76f60bf75ade5eb0822513
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java
e44cfca8ee4a4b38f51cf1a12d7b9a51480845ca
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
e8031066c2dc9b1b40be570e9098ac0c55d997be
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListenerOnlyOnCommit.java
9623fedff90d0ccb2e3d668ae4ca2f0f18d7dc46
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreInitListener.java
49823134a7714be61a1a4202621ab31b5739a226
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreListenersError.java
11ebf4d961ce9bcfeda671c1be394e19f5e98eb4
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java
6f5a963e16509ac45c48702335eec1c7baa9ef22
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreVersion.java
0a034d3593468b1704769fa2b0fde2330d61b546
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java
1fd84ac438dd36d1d867afc00a037b8749779667
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestCreateUdfEntities.java
34f4ed0490f23378a6dc832cf0cbca2f81c94a81
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDDLWithRemoteMetastoreSecondNamenode.java
179eed95d0be28056d0bb7ed6a8b63910a7594ac
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
d73cd6426cefceac35922314b208e92d23e52b1c
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/metadata/TestSemanticAnalyzerHookLoading.java
2170ca3706d0c21df3a630b8b0112eb188a96b16
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
55acd1df3697f1742c826f1cd9648634811b915f
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/WarehouseInstance.java
cde7a3e33cdadafe58e441fe65126636ef3c7bae
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java
dc3af3c18696bf7ce14b6139e4686c340b3fff32
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestAuthorizationPreEventListener.java
6a668aa40c856f90d09da4eb8941a0e7e0a70f19
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestClientSideAuthorizationProvider.java
57ff8c9ae7edc71b12a46ce63387e0ebdef58b22
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java
edb46fd97903e409644c97b1aebefdb75a99de01
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMultiAuthorizationPreEventListener.java
2059370fd40c49ca0016ee8179512d325768331b
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java
19694b093e5aa3af419409f725c228af912cf435
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java
5922a8c603e1597d6091b6fb64527d2c75f15a9c
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
75eeaf61d6519987f6ea6e3d0641f326b99dfb34
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
88034d764358ff91c8a6fdf824f6cda513cace3f
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
b168906b440d14dfebab381d2109d11467437e2b
ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/IDriver.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/QueryLifeTimeHookRunner.java
6bdf7ebf47001fde89b5fdd20e63e4e69a55d6d5
ql/src/java/org/apache/hadoop/hive/ql/exec/DagUtils.java
aed1b2cf53d97577d058550f51ec3adfef9cb0a6
ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java
4380fe33b6ca35a826052c7820a188a3c60c2ec2
ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
00087267c735bb9a915e67ee041fa3bb2f4b5a8c
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
8d0690d33ebf96e714a0d9cd8239aba0273733a5
ql/src/test/queries/clientpositive/retry_tez_failure.q PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
773dd51c9a6c5d4982db7ecbed8ea26ecdc8c919
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
cc4dd52fcf7987e468e477d81a89b03b80158419
Diff: https://reviews.apache.org/r/64712/diff/1/
Testing
-------
doesn't break any tests
Thanks,
Zoltan Haindrich
