----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ -----------------------------------------------------------
(Updated Jan. 17, 2018, 2:27 a.m.) Review request for hive, Eugene Koifman and Jason Dere. Changes ------- Implemented review comments. Added a test for ACID tables. Removed the strict ACID check which ensured that files are named in format 000000_0, 000000_0_copy_1 etc. The renaming is now done explicitely for non-bucketed tables. Bugs: HIVE-18350 https://issues.apache.org/jira/browse/HIVE-18350 Repository: hive-git Description ------- Made changes for both bucketed and non-bucketed tables. Added a positive test for non-bucketed table which renames the loaded file. Added couple of negative tests for bucketed table which reject a load with inconsistent file name. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java d68d646eb4 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1a2b3c1f6c ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 4535c3edc2 ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java cc1d8574b0 ql/src/test/queries/clientnegative/load_data_bucketed_1.q PRE-CREATION ql/src/test/queries/clientnegative/load_data_bucketed_2.q PRE-CREATION ql/src/test/queries/clientpositive/load_data_rename.q PRE-CREATION ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 ql/src/test/results/clientnegative/load_data_bucketed_1.q.out PRE-CREATION ql/src/test/results/clientnegative/load_data_bucketed_2.q.out PRE-CREATION ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 ql/src/test/results/clientpositive/llap/load_data_rename.q.out PRE-CREATION ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 Diff: https://reviews.apache.org/r/65130/diff/4/ Changes: https://reviews.apache.org/r/65130/diff/3-4/ Testing ------- Thanks, Deepak Jaiswal