----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 -----------------------------------------------------------
Thanks for the patch Adam. Questions, and some minor comments. Thanks, Peter standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 52 (patched) <https://reviews.apache.org/r/65217/#comment275113> nit: We should import everything which is needed standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 122 (patched) <https://reviews.apache.org/r/65217/#comment275112> nit: Why static? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 150 (patched) <https://reviews.apache.org/r/65217/#comment275111> nit: Can we stick to one notation? I do not like _ in function names :) standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 181 (patched) <https://reviews.apache.org/r/65217/#comment275115> These are the only parameters which can be changed? If so should not we check the other paramteres are not changed in assertPartitionChanged? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 298 (patched) <https://reviews.apache.org/r/65217/#comment275132> nit: We might want to add TODO comments to places where we think we want to change standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 450 (patched) <https://reviews.apache.org/r/65217/#comment275133> Question: Maybe in setup? - Peter Vary On Jan. 18, 2018, 2:26 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65217/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 2:26 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18468 > https://issues.apache.org/jira/browse/HIVE-18468 > > > Repository: hive-git > > > Description > ------- > > Adding IMetastoreClient API tests that cover alterPartition ande > renamePartition methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65217/diff/1/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
