----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195796 -----------------------------------------------------------
Overall looks good, I just have small observations. One more nitpick: some helper methods could be static e.g. getYearAndMonthCols standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java Lines 64 (patched) <https://reviews.apache.org/r/65213/#comment275117> Is there any reason to use 10? Supplying -1 would return all partitions which I think was the original intent in the test cases below (in listPartitions calls). standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java Lines 165 (patched) <https://reviews.apache.org/r/65213/#comment275130> createTable is called here twice because it's also in @Before. Does this mean it overrides the existing table with the supplied tableParams? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java Lines 539-553 (patched) <https://reviews.apache.org/r/65213/#comment275116> Guava lib has a handy method for these use cases: <E> ArrayList<E> com.google.common.collect.Lists.newArrayList(E... elements) ...which is doing exactly the same + optimising on initial list size. - Adam Szita On Jan. 18, 2018, 1:11 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65213/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 1:11 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18479 > https://issues.apache.org/jira/browse/HIVE-18479 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - boolean dropPartition(String, String, List<String>, boolean) > - boolean dropPartition(String, String, List<String>, PartitionDropOptions) > - boolean dropPartition(String, String, String, boolean) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65213/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >