----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195811 -----------------------------------------------------------
Thanks Marta for the patch. Some questions below. Also I think it would be nice to have test for the default values when adding a partition. Thanks, Peter standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 236 (patched) <https://reviews.apache.org/r/65219/#comment275136> There are some interesting validation in the SD. Maybe we can add test for it here too. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 282 (patched) <https://reviews.apache.org/r/65219/#comment275137> Is it worth to create a test for an External Table too? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 700 (patched) <https://reviews.apache.org/r/65219/#comment275138> Like above - validation inside the SD might be important as well standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 749 (patched) <https://reviews.apache.org/r/65219/#comment275139> Maybe for external table too. And maybe check the locations standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 1117 (patched) <https://reviews.apache.org/r/65219/#comment275135> I do not understand this check - Peter Vary On Jan. 18, 2018, 4:58 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65219/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 4:58 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18486 > https://issues.apache.org/jira/browse/HIVE-18486 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - Partition add_partition(Partition) > - int add_partitions(List<Partition>) > - List<Partition> add_partitions(List<Partition>, boolean, boolean) > > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65219/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >