-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65172/#review195863
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java
Lines 63 (patched)
<https://reviews.apache.org/r/65172/#comment275199>

    More readable name: CBOSupportedLateralViews and then flip meaning of 
boolean.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 880 (patched)
<https://reviews.apache.org/r/65172/#comment275203>

    Better name: CBOsupportedLateralView ?



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 2701 (patched)
<https://reviews.apache.org/r/65172/#comment275200>

    Whats PTF node? Is it over clause? If so, can we add some tests for it.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 2718-2723 (patched)
<https://reviews.apache.org/r/65172/#comment275201>

    Can be written with lambda syntax. More readably.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 2734 (patched)
<https://reviews.apache.org/r/65172/#comment275202>

    with instead of and in sentence ?


- Ashutosh Chauhan


On Jan. 15, 2018, 11:52 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65172/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 11:52 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-18450
>     https://issues.apache.org/jira/browse/HIVE-18450
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-18450
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java 
> 69a750bb3c88f976396f5306d2d39d305754b7a5 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java
>  bf4896d61d594dfc076611b4a9c422fee8c18383 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 572b95f9603ba7570734cff8172dfe6a49b9b37d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g 
> b038e8185de5e0457ff02cdbf7372f03f6a2a9d9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c558356a4e9cca628e7590e48c0d6ec503bc594e 
>   ql/src/test/queries/clientpositive/tablevalues.q 
> 501f532eb7fe9bbe8dfe013b8af5883823b3e0c9 
>   ql/src/test/results/clientpositive/tablevalues.q.out 
> 247c5647a3614bcf031586665752dfc69fd051ce 
> 
> 
> Diff: https://reviews.apache.org/r/65172/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Reply via email to