----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65047/#review195935 -----------------------------------------------------------
Overall, looks good to me. I'm really not that familiar with the serde / OI classes. So maybe someone else should take a look. Alternatively, a brief description of what these classes do and how they work would be very helpful. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/primitive/ParquetStringInspector.java Lines 64 (patched) <https://reviews.apache.org/r/65047/#comment275345> do we need to handle all the others types like date, interval, or any of the comples types like array, struct, union, etc. - Sahil Takiar On Jan. 18, 2018, 5:34 p.m., Janaki Lahorani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65047/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 5:34 p.m.) > > > Review request for hive, Aihua Xu, Alexander Kolbasov, Andrew Sherman, > Ashutosh Chauhan, cheng xu, ferdy, Alan Gates, Owen O'Malley, Sergey > Shelukhin, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > Data saved as TimeStamp, Decimal, Double, Float, BigInt, Int, SmallInt, > Tinyint and Boolean, after the type is changed to String, VarChar or Char > will return correct results. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/primitive/ParquetStringInspector.java > 70a92ab3bc9d3b2ecc205fad274e8c639812e59a > ql/src/test/queries/clientpositive/typechangetest.q PRE-CREATION > ql/src/test/results/clientpositive/typechangetest.q.out PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveCharObjectInspector.java > 3204e309686f295810c1e850c8028303b2f5f7ff > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java > 8ac2d8477e1071f95d3f5faed8a7be92c76e6347 > > > Diff: https://reviews.apache.org/r/65047/diff/4/ > > > Testing > ------- > > > Thanks, > > Janaki Lahorani > >
