----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review196012 -----------------------------------------------------------
Fix it, then Ship it! Looking good, thanks Peter! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 234-235 (patched) <https://reviews.apache.org/r/65265/#comment275544> Could use assertEquals here instead IMHO standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 429 (patched) <https://reviews.apache.org/r/65265/#comment275528> Is this line of code necessary here? - Adam Szita On Jan. 23, 2018, 11:48 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65265/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 11:48 a.m.) > > > Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. > > > Bugs: HIVE-18509 > https://issues.apache.org/jira/browse/HIVE-18509 > > > Repository: hive-git > > > Description > ------- > > Added the new tests. > Modified AbstractMetaStoreService, so when starting mini-metastore it is > possible to provide configuration value overrides for non-metastore config > values (like fs trash settings) > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java > ed071f8 > > > Diff: https://reviews.apache.org/r/65265/diff/3/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
