----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196236 -----------------------------------------------------------
Thanks a lot Adam for the patch. It looks really good to me, I just have few questions. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 762-765 (patched) <https://reviews.apache.org/r/65284/#comment275778> Is this the same use case as in the testListPartitionsByFilterEmptyFilter test? If it is, I think it is enough to have only one test for this use case. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 871-873 (patched) <https://reviews.apache.org/r/65284/#comment275779> The same as above. If it is the same use case as in testListPartitionSpecsByFilterEmptyFilter, I think it would enought to have only the one of them. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 1028-1031 (patched) <https://reviews.apache.org/r/65284/#comment275780> What is the expected behaviour in this case? Should the getNumPartitionsByFilter return 0 or an other value? - Marta Kuczora On Jan. 24, 2018, 11:22 a.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65284/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 11:22 a.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18484 > https://issues.apache.org/jira/browse/HIVE-18484 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover listPartition(s) methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65284/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
