With all of the added tests in standalone-metastore/…/client directory, the
runtime of ‘mvn test’ in standalone-metastore went from 6 minutes to 26 on
my humble laptop.  We do not want to get ourselves back where the rest of
Hive is; currently Hive developers don’t run the unit tests themselves
because the tests take too long.  I believe we should be working to push
the unit test runtime down to about 2 minutes, so people are willing to run
it frequently as part of their development.

I don’t mean that the new tests aren't valuable.  But we need a balance
between test coverage in the unit tests and usability.  So I propose that
we carve off many of the current unit tests (including some not in the
client module, like TestSetUGI…, TestRemote...) in a new profile,
‘nightly’, or ‘checkin’, or something.  Then ‘mvn install’ will finish
quickly while hopefully covering 90% of the areas we need to cover.  We can
ask developers to run the extended set before checkin and configure the
automated tests to do the same.  This way we still cover everything before
committing.

Seem reasonable?

Alan.

Reply via email to