----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196609 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 3784 (patched) <https://reviews.apache.org/r/65276/#comment276302> how is isFullAcidTable different from isAcid ? There should be some java doc if they are indeed different ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java Lines 460 (patched) <https://reviews.apache.org/r/65276/#comment276303> is this left in here intentionally? checkExpected() logs this to the log file laready ql/src/test/queries/clientpositive/load_data_acid_rename.q Lines 1 (patched) <https://reviews.apache.org/r/65276/#comment276299> why is this needed here? this is deperecated in HiveConf - Eugene Koifman On Jan. 31, 2018, 10 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65276/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 10 p.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-18516 > https://issues.apache.org/jira/browse/HIVE-18516 > > > Repository: hive-git > > > Description > ------- > > load data should rename files consistent with insert statements for ACID > Tables. > Includes test change for a missed test. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties d86ff58840 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 5868d4dd56 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java a9cba456ef > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java > c6a4a8926b > ql/src/test/queries/clientnegative/load_data_into_acid.q 2ac5b561ae > ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION > ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 > ql/src/test/results/clientnegative/load_data_into_acid.q.out 46b5cdd2c8 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 > ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out > PRE-CREATION > ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 > ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 > > > Diff: https://reviews.apache.org/r/65276/diff/5/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
