----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65431/#review196691 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java Line 781 (original), 781 (patched) <https://reviews.apache.org/r/65431/#comment276467> Should leave a TODO that if not null constraint is enabled on existing table via alter statement, we need to validate existing data which we currently don't. ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java Line 795 (original), 795 (patched) <https://reviews.apache.org/r/65431/#comment276469> instead : if (enable && !constraintName.equals("not null")) ? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 6700 (patched) <https://reviews.apache.org/r/65431/#comment276471> Add dest in error msg. ql/src/test/queries/clientpositive/enforce_constraint_notnull.q Lines 88-89 (patched) <https://reviews.apache.org/r/65431/#comment276472> We need -ve test for this as well where query fails because of constraint violation. ql/src/test/queries/clientpositive/enforce_constraint_notnull.q Lines 92 (patched) <https://reviews.apache.org/r/65431/#comment276473> We need -ve test for this as well where query fails because of constraint violation after enabling constraints. ql/src/test/queries/clientpositive/enforce_constraint_notnull.q Lines 114 (patched) <https://reviews.apache.org/r/65431/#comment276474> We need -ve test for this as well where query fails because of constraint violation. ql/src/test/queries/clientpositive/enforce_constraint_notnull.q Lines 148-149 (patched) <https://reviews.apache.org/r/65431/#comment276475> We need -ve test for this as well where query fails because of constraint violation. - Ashutosh Chauhan On Jan. 31, 2018, 8:42 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65431/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 8:42 a.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-16605 > https://issues.apache.org/jira/browse/HIVE-16605 > > > Repository: hive-git > > > Description > ------- > > This patch introduces support for enable NOT NULL constraint enforcement for > following type of statements: > > * INSERT INTO > * INSERT as SELECT > * INSERT OVERWRITE > * UPDATE > * MERGE > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a > itests/src/test/resources/testconfiguration.properties d86ff58840 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 372cfad866 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > dbf9363d11 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > 9fcde76d21 > ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java e3a9e62bdb > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_enable.q > 59ebb1e9b2 > ql/src/test/queries/clientnegative/create_with_constraints_enforced.q > 5b90c0efc9 > ql/src/test/queries/clientnegative/insert_into_acid_notnull.q PRE-CREATION > ql/src/test/queries/clientnegative/insert_into_notnull_constraint.q > PRE-CREATION > ql/src/test/queries/clientnegative/insert_multi_into_notnull.q PRE-CREATION > ql/src/test/queries/clientnegative/insert_overwrite_notnull_constraint.q > PRE-CREATION > ql/src/test/queries/clientpositive/enforce_constraint_notnull.q > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_enable.q.out > 2b244120e9 > ql/src/test/results/clientnegative/create_with_constraints_enforced.q.out > 2b244120e9 > ql/src/test/results/clientnegative/insert_into_acid_notnull.q.out > PRE-CREATION > ql/src/test/results/clientnegative/insert_into_notnull_constraint.q.out > PRE-CREATION > ql/src/test/results/clientnegative/insert_multi_into_notnull.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/insert_overwrite_notnull_constraint.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 43e4a5de39 > > > Diff: https://reviews.apache.org/r/65431/diff/1/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
