----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65479/#review196840 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/IConfigureJobConf.java Lines 24 (patched) <https://reviews.apache.org/r/65479/#comment276668> Add: Intended only for compilation phase. ql/src/java/org/apache/hadoop/hive/ql/exec/IConfigureJobConf.java Lines 24 (patched) <https://reviews.apache.org/r/65479/#comment276670> Add: Only during compilation. ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java Lines 259 (patched) <https://reviews.apache.org/r/65479/#comment276666> Is this needed? ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapRunner.java Lines 29 (patched) <https://reviews.apache.org/r/65479/#comment276667> Why do we need this class? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java Line 247 (original), 246-248 (patched) <https://reviews.apache.org/r/65479/#comment276672> This may result in extra memory allocation. If this change is not necessary, can we leave it as is? ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java Lines 453 (patched) <https://reviews.apache.org/r/65479/#comment276669> Please add comment. ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java Lines 580 (patched) <https://reviews.apache.org/r/65479/#comment276674> Add comment on need for this. ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java Lines 505 (patched) <https://reviews.apache.org/r/65479/#comment276673> Add comment on need for this. ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java Lines 213 (patched) <https://reviews.apache.org/r/65479/#comment276671> Do we need this? Reducers are always launched when when there is no mapper. So, this seems unnecessary. - Ashutosh Chauhan On Feb. 2, 2018, 12:23 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65479/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 12:23 p.m.) > > > Review request for hive, Ashutosh Chauhan and Prasanth_J. > > > Bugs: HIVE-18523 > https://issues.apache.org/jira/browse/HIVE-18523 > > > Repository: hive-git > > > Description > ------- > > * ensure that mapper operators are started up - but only if empty grouping is > present > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java > 6a0f0de2a5e84770c6446af41710d972d813c7bc > ql/src/java/org/apache/hadoop/hive/ql/exec/IConfigureJobConf.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > d7b3e4b2fd3ee1a8e2795095a6c55442de2b38e0 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java > 976b537033abda5d5ab8b77a7e7d6fb9c84e5a19 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapRunner.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java > 150382a8d58fd4ba44e4d9b78a80173ab984e776 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java > 98f4bc01c8526422348a38f8d8632e0899d695ee > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java > 45d809a1820fcb6ea5e1e5c15aee7de91a4c36c8 > ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java > e4dfc009d95f4302bd1fcdff2276e11bed68d2e0 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f > ql/src/java/org/apache/hadoop/hive/ql/io/NullRowsInputFormat.java > 6a372a3f47e3ac2ae2b2e583541b3a19e5d525f3 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java > f2b2fc57a03b368707968eb503139e51218008ca > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java > ecfb118b41bfa5b7d593b7e801a37f0a7b5b0b5e > ql/src/test/queries/clientpositive/groupby_rollup_empty.q > 432d8c448a05f51db9ecf9940bce599dfd598a70 > ql/src/test/results/clientpositive/groupby_rollup_empty.q.out > 7359140e29fc63eebbab42ab385187be6bfc66e1 > ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out > d2b57455a3640387d8bc5f2d415a7af25eb55341 > > > Diff: https://reviews.apache.org/r/65479/diff/1/ > > > Testing > ------- > > added new testcase for union > > > Thanks, > > Zoltan Haindrich > >
