> On Feb. 6, 2018, 3:06 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q > > Lines 71 (patched) > > <https://reviews.apache.org/r/65478/diff/2/?file=1952940#file1952940line71> > > > > Can you please test using timestamps as well. Specifically, the > > following should work. > > > > drop table test_alter2; > > create table test_alter2 (ts timestamp) stored as parquet; > > insert into test_alter2 values ('2018-01-01 13:14:15.123456'), > > ('2018-01-02 14:15:16.123456'), ('2018-01-03 16:17:18.123456'); > > select * from test_alter2; > > alter table test_alter2 replace columns (ts string); > > select * from test_alter2; > > > > > > drop table test_alter2; > > create table test_alter2 (ts timestamp) stored as parquet; > > insert into test_alter2 values ('2018-01-01 13:14:15.123456'), > > ('2018-01-02 14:15:16.123456'), ('2018-01-03 16:17:18.123456'); > > select * from test_alter2; > > alter table test_alter2 replace columns (ts varchar(19)); > > -- this should truncate the microseconds > > select * from test_alter2; > > > > > > drop table test_alter2; > > create table test_alter2 (ts timestamp) stored as parquet; > > insert into test_alter2 values ('2018-01-01 13:14:15.123456'), > > ('2018-01-02 14:15:16.123456'), ('2018-01-03 16:17:18.123456'); > > select * from test_alter2; > > alter table test_alter2 replace columns (ts char(25); > > select * from test_alter2;
I test non vectorization path and all of these test cases failed due to not abled to type cast error. Any thoughts on this? - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196867 ----------------------------------------------------------- On Feb. 5, 2018, 4:46 p.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65478/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 4:46 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > VectorizedParquetReader throws an exception when trying to reading from a > parquet table on which new columns are added. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/BaseVectorizedColumnReader.java > 907a9b8 > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedDummyColumnReader.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java > 08ac57b > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestVectorizedColumnReader.java > 9e414dc > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/VectorizedColumnReaderTestBase.java > 5d3ebd6 > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q PRE-CREATION > ql/src/test/results/clientpositive/schema_evol_par_vec_table.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65478/diff/2/ > > > Testing > ------- > > Newly added UT passed and qtest passed locally. > > > Thanks, > > cheng xu > >
