----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65543/#review197292 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/IDriver.java Line 66 (original), 68 (patched) <https://reviews.apache.org/r/65543/#comment277416> HCat cli will be removed soon, so we may ignore that. ql/src/java/org/apache/hadoop/hive/ql/QueryState.java Lines 181 (patched) <https://reviews.apache.org/r/65543/#comment277430> I don't see this being used everywhere. Whats the purpose of this? - Ashutosh Chauhan On Feb. 7, 2018, 9:36 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65543/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2018, 9:36 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18238 > https://issues.apache.org/jira/browse/HIVE-18238 > > > Repository: hive-git > > > Description > ------- > > hs2 already uses separate driver instance to execute commands ; these changes > make the cli also do the same - since we are using cli to run tests... > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java > a78e0c63d792230c19493514be1ed7bd992eeebe > hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java > ad31287879930386838ca19533ce67df08349dc1 > hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatDriver.java > 533f0bcd6f5a12606de46a1b986270789dd52233 > hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java > 4dbf7acb9d569dd608b83ca7db0f6e18d0c3d02b > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java > b70a9529d895fddc3cb7debc37dba36a1afb4c7e > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java > 2be86f8b4259de3e5c1d78d9bdd2c3a53505e3c4 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 74595b00f9d35e3a850b2ef3550d2909a83880cf > ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java > 49d2bf5f335c6806460fb6b83ee4da8bf842bd5a > ql/src/java/org/apache/hadoop/hive/ql/IDriver.java > 6280be0b08a657a452cc39dacb42c9cf396bd880 > ql/src/java/org/apache/hadoop/hive/ql/QueryState.java > d8d19e86061846c446fbb60e7ed827c6ba6fb7fc > ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java > 5a370e89a9e93da2191431acc1a66c69c94d1372 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java > cf8bc7f256db4a4f559aa1c79c76201de620f141 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java > d750e772150088295643b99d4496b3ded2e104c0 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > b67a03f2138cc5f47135f4a6ecf55dd3bd1c20fc > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java > 5fcbd6964429dd6aa7c70ded47fa862b356cfd88 > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessor.java > 3624d08ee82ecb4822767312e9cfdaf3fea5c98b > > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java > dcf8d31eaf769ca198e9877c73bf4bce81d3f3c4 > ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java > 07d70ab5634044f48dc3401185ab7c132dbb7476 > ql/src/java/org/apache/hadoop/hive/ql/processors/CryptoProcessor.java > 6825dd83a4953eb97279f9e39deca072d057dfe7 > > ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java > 54a7d4b0de6fd8d79517b616ed2fff24e1e36370 > ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java > 2f288ce8b8234b2f3da58729f998124f6858608b > ql/src/java/org/apache/hadoop/hive/ql/processors/ListResourceProcessor.java > 7ec36be61db680e2ce2471d13c954ac87935f473 > ql/src/java/org/apache/hadoop/hive/ql/processors/ReloadProcessor.java > b82bd5ce99b47e81b88984f47cce625c97170c34 > ql/src/java/org/apache/hadoop/hive/ql/processors/ResetProcessor.java > 144f5223d3e8664cc424c40abe046b23c97382c8 > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java > 1ff4b3c9479fccc0bc6c137eb0d1be7953594c4f > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java > 4508e59a8bdde571740a1e5c08652c564958d350 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > d56002d192c9faf5a656386fc933f7d84e1b1204 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java > 048215aa376e4b561cf5fe07bec88397441dc7fb > ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java > 93074e998d42147eae54f0993d9ee53072e2e36a > ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperators.java > df19d72411cb901a996f2d3ff0ee6d0b6ae200c7 > ql/src/test/org/apache/hadoop/hive/ql/hooks/TestQueryHooks.java > 06628750e250c449d5695640cffda4f8ac924a17 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > 71d960f4c99b6874d35e7547c73d3a787c04b864 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java > 2f5fc2fff1931a7c57f6f4805d6096aa1a09ae59 > ql/src/test/queries/clientpositive/driver_conf_isolation.q PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q > c017172fd18b94fd870a2dcd79e0d205fc4076cc > ql/src/test/results/clientpositive/driver_conf_isolation.q.out PRE-CREATION > ql/src/test/results/clientpositive/input39.q.out > 3000404448c05b57c4bced986e8e2d3b305848b2 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 2ef14795401cd9be786494f4652b844e3fb4b283 > > > Diff: https://reviews.apache.org/r/65543/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
