----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65755/#review198126 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java Line 824 (original), 824 (patched) <https://reviews.apache.org/r/65755/#comment278235> as I've noted earlier in the jira: a statistic with 0 rows is fine; but only if its up-to-date (areBasicStatsUpToDate) I don't think we should be excluding 0 in any way; that would just "cover-up" some simple cases; and make it harder to track down if basic state is not maintained correctly. - Zoltan Haindrich On Feb. 22, 2018, 2:50 p.m., Oleksiy Sayankin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65755/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 2:50 p.m.) > > > Review request for hive, Ashutosh Chauhan, Zoltan Haindrich, and Zoltan > Haindrich. > > > Repository: hive-git > > > Description > ------- > > Initial commit > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 85f198b > > > Diff: https://reviews.apache.org/r/65755/diff/1/ > > > Testing > ------- > > > Thanks, > > Oleksiy Sayankin > >
