> On Feb. 21, 2018, 10:07 p.m., Daniel Dai wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 311 (original), 215 (patched) > > <https://reviews.apache.org/r/65634/diff/1/?file=1958990#file1958990line316> > > > > This is not introduced in this patch, but getting columns for table and > > apply to partition will not work for schema revolution. We shall get > > columns for every individual partition.
I agree, but not sure if current stats works with schema evolution. Let me take this up in a follow up jira as this might need a little more thought. > On Feb. 21, 2018, 10:07 p.m., Daniel Dai wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 800 (original), 632 (patched) > > <https://reviews.apache.org/r/65634/diff/1/?file=1958990#file1958990line881> > > > > I don't remember but why this is get() not getUnsafe()? It sounds the > > same as getAllTables etc. Also apply to getDatabases, alterDatabase, > > dropDatabase, getDatabase and createDatabase We're using get() here so that this call blocks till the database cache is populated. We're letting reads go through the cache while the tables are getting populated, but not for databases. Let me know if you think otherwise. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review197794 ----------------------------------------------------------- On Feb. 13, 2018, 12:08 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65634/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 12:08 p.m.) > > > Review request for hive, Daniel Dai and Thejas Nair. > > > Bugs: HIVE-18264 > https://issues.apache.org/jira/browse/HIVE-18264 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-18264 > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 78b26374f2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > d58ed677f3 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > e4e7d4239d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java > f0f650ddcf > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 80aa3bcdb4 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java > 32ea17495f > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 9100c73beb > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 86e72d8d76 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java > bd61df654a > > > Diff: https://reviews.apache.org/r/65634/diff/1/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
