----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65803/#review198282 -----------------------------------------------------------
added some notes about the q.out changes ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Lines 148 (patched) <https://reviews.apache.org/r/65803/#comment278391> I will remove this FIXME on commit should the second one be kept at the end of this function? ql/src/test/results/clientpositive/llap/join46.q.out Line 2089 (original) <https://reviews.apache.org/r/65803/#comment278383> I think that changes like this are "ok"; since it seems that the sel operator in this case have became a shared work ql/src/test/results/clientpositive/llap/llap_partitioned.q.out Line 1713 (original), 1713 (patched) <https://reviews.apache.org/r/65803/#comment278384> the old value seems to be totally bad...2640 aligns with the TS stat ; should this be investigated separetly? ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Line 490 (original), 490 (patched) <https://reviews.apache.org/r/65803/#comment278385> the datasize here is doubled; because of bug in statsutils; because I think the issue appears in other places as well; I would like to address this separetly with [HIVE-18804](https://issues.apache.org/jira/browse/HIVE-18804) ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Line 595 (original), 595 (patched) <https://reviews.apache.org/r/65803/#comment278386> ds multiplied; [HIVE-18804|https://issues.apache.org/jira/browse/HIVE-18804] ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Line 744 (original), 744 (patched) <https://reviews.apache.org/r/65803/#comment278387> ds multiplied; [HIVE-18804|https://issues.apache.org/jira/browse/HIVE-18804] ql/src/test/results/clientpositive/llap/subquery_in_having.q.out Line 1570 (original), 1570 (patched) <https://reviews.apache.org/r/65803/#comment278388> I guess these are because some operators are not "manufactured" in the op-factory due to an optimization have kicked in and made it unneccessary - should this be investigated? ql/src/test/results/clientpositive/llap/subquery_multi.q.out Line 3992 (original) <https://reviews.apache.org/r/65803/#comment278389> this is a common filter; appearing on the other branch as well ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out Line 62 (original), 62 (patched) <https://reviews.apache.org/r/65803/#comment278390> this is an intresting one...when stats annotation have run there was a FIL operator above it; which had a different stat value - might be HIVE-18804 as well; but around that time it was not yet clear... anyway: the new stat value seems to fit more the plan.. - Zoltan Haindrich On Feb. 26, 2018, 1:35 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65803/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2018, 1:35 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18805 > https://issues.apache.org/jira/browse/HIVE-18805 > > > Repository: hive-git > > > Description > ------- > > added an earlier invocation > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java > f9a6386ecf93f5de86de67cd383d6f140729bf08 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out > cab45c9410f44d9fdb4d06a3940be253c5ad1524 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out > 43ca0d9ad718eec92663027f824f89cff9ca5de0 > ql/src/test/results/clientpositive/llap/join32_lessSize.q.out > 5b5be1370251519e1ae236e24acf96a17c5ed311 > ql/src/test/results/clientpositive/llap/join46.q.out > 4625b9fed8fa3736c56bec91d42dfa1e7e916168 > ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out > 4dd7432ac50ebef54d15f72399ecdc3d284010c4 > ql/src/test/results/clientpositive/llap/llap_partitioned.q.out > ac754674ea82c5037808d3ed2a8c9dd7fe12cca5 > ql/src/test/results/clientpositive/llap/mapjoin46.q.out > f530c1e8e1b654bc621f1619df6bbc6d09e3ae7f > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out > cdfa73349b5913a1ab07b902095e9c1716b77cdd > ql/src/test/results/clientpositive/llap/subquery_in_having.q.out > cc0b6a597aa2309376c62140f623debedac7aa8f > ql/src/test/results/clientpositive/llap/subquery_multi.q.out > 67a22c812f01a1207f6ec1d5fc8621e523f59582 > ql/src/test/results/clientpositive/llap/subquery_notin.q.out > 50c18c8a68984dacd26cfdec9925a26e856b467d > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out > cec3daa08593e0c9eb789ef6591f8c3463224a5b > ql/src/test/results/clientpositive/llap/subquery_select.q.out > 89eab37d07b9d37806033e1b2ebf59cbe12d014f > ql/src/test/results/clientpositive/llap/tez_join_tests.q.out > 75879fb157397408f4bd425494f2c9d8e8426010 > ql/src/test/results/clientpositive/llap/tez_joins_explain.q.out > 3790b37760d23c9f3f49a849de6466ddff9814dc > > ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out > 07c1e4188c8afa9c5793c2f5890a3af9acd6a6c9 > ql/src/test/results/clientpositive/perf/tez/query72.q.out > 55ddd5a0f867052ac2cfbc1682978f8f03c1fce3 > ql/src/test/results/clientpositive/perf/tez/query78.q.out > 9c2d7b3491fa7c40ef72967e6eecca7f7f689a02 > > > Diff: https://reviews.apache.org/r/65803/diff/1/ > > > Testing > ------- > > run precommit > > > Thanks, > > Zoltan Haindrich > >
