----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/#review198298 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java Lines 409 (patched) <https://reviews.apache.org/r/65778/#comment278412> What about other types: char, varchar, timestamp, tstz, decimal etc. If those are not needed, can you add a comment about it? ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultConstraint.java Lines 34 (patched) <https://reviews.apache.org/r/65778/#comment278413> Is there a reason to implement Serializable ? ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java Lines 803 (patched) <https://reviews.apache.org/r/65778/#comment278414> I wonder if this is ever useful. Does standard allows currentDB? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 4402 (patched) <https://reviews.apache.org/r/65778/#comment278416> can remove this. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 4409 (patched) <https://reviews.apache.org/r/65778/#comment278417> Does this mean: default value was specified as null ? We won't serialize null in metastore? If so, can you add comment about this. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 4411 (patched) <https://reviews.apache.org/r/65778/#comment278418> LOG.debug("Added default value from metastore: " + exp) ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 12595 (patched) <https://reviews.apache.org/r/65778/#comment278419> They can be added later. Can you leave a TODO? ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java Lines 120-128 (patched) <https://reviews.apache.org/r/65778/#comment278420> Covered in different patch. ql/src/test/queries/clientnegative/constraint_partition_columns.q Lines 1 (patched) <https://reviews.apache.org/r/65778/#comment278421> We can support this later. Effectively, replace __HIVE_DEFAULT_PARTITION_ crux we have. ql/src/test/queries/clientpositive/default_constraint.q Lines 1 (patched) <https://reviews.apache.org/r/65778/#comment278423> Can you create all these tables as ACID? We primarily want to test this feature for ACID tables. ql/src/test/results/clientnegative/default_constraint_invalid_default_value_type.q.out Lines 1 (patched) <https://reviews.apache.org/r/65778/#comment278424> Can you also add -ve test disallowing complex type in default value. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1538-1539 (patched) <https://reviews.apache.org/r/65778/#comment278425> These 2 lines Can be collapsed on single line. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 2309 (patched) <https://reviews.apache.org/r/65778/#comment278426> LOG.debug(queryText) standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 9672 (patched) <https://reviews.apache.org/r/65778/#comment278427> Can you add directsql=false for one of the queries in test to cover this code path? - Ashutosh Chauhan On Feb. 23, 2018, 9:52 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65778/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 9:52 p.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-18726 > https://issues.apache.org/jira/browse/HIVE-18726 > > > Repository: hive-git > > > Description > ------- > > This patch adds DEFAULT constraint > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > a3725c5395 > itests/src/test/resources/testconfiguration.properties 4a52eb5559 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 6cd7a136ae > metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql a8f227b775 > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 84d523e1d7 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java f99178dbc7 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 32fc257b03 > ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultConstraint.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8b0af3e5c8 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 77e5678f80 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > a5b6a4b0c3 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java > 88d5554e1d > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 607e111c97 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 171825eb74 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > e926b63764 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 733ec79ce1 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > cd6f1ee692 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > 14217e3978 > > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/AddNotNullConstraintHandler.java > 9c12e7e2af > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 00c0381107 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 6228d4c803 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java > 73f449fc28 > ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java fcbac7d840 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToChar.java > b98ec68158 > ql/src/test/queries/clientnegative/alter_external_with_constraint.q > ql/src/test/queries/clientnegative/alter_external_with_default_constraint.q > PRE-CREATION > > ql/src/test/queries/clientnegative/alter_tableprops_external_with_constraint.q > > > ql/src/test/queries/clientnegative/alter_tableprops_external_with_default_constraint.q > PRE-CREATION > ql/src/test/queries/clientnegative/constraint_duplicate_name.q PRE-CREATION > ql/src/test/queries/clientnegative/constraint_invalide_name.q PRE-CREATION > ql/src/test/queries/clientnegative/constraint_partition_columns.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_external_with_constraint.q > > ql/src/test/queries/clientnegative/create_external_with_default_constraint.q > PRE-CREATION > > ql/src/test/queries/clientnegative/default_constraint_invalid_default_value.q > PRE-CREATION > > ql/src/test/queries/clientnegative/default_constraint_invalid_default_value2.q > PRE-CREATION > > ql/src/test/queries/clientnegative/default_constraint_invalid_default_value_length.q > PRE-CREATION > > ql/src/test/queries/clientnegative/default_constraint_invalid_default_value_type.q > PRE-CREATION > ql/src/test/queries/clientnegative/default_constraint_invalid_type.q > PRE-CREATION > ql/src/test/queries/clientpositive/create_with_constraints.q 7b2594b79f > ql/src/test/queries/clientpositive/default_constraint.q PRE-CREATION > ql/src/test/results/clientnegative/alter_external_with_constraint.q.out > > ql/src/test/results/clientnegative/alter_external_with_notnull_constraint.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/alter_tableprops_external_with_constraint.q.out > > > ql/src/test/results/clientnegative/alter_tableprops_external_with_default_constraint.q.out > PRE-CREATION > ql/src/test/results/clientnegative/constraint_duplicate_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/constraint_invalide_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/constraint_partition_columns.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_external_with_constraint.q.out > > ql/src/test/results/clientnegative/create_external_with_notnull_constraint.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/default_constraint_invalid_default_value.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/default_constraint_invalid_default_value2.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/default_constraint_invalid_default_value_length.q.out > PRE-CREATION > > ql/src/test/results/clientnegative/default_constraint_invalid_default_value_type.q.out > PRE-CREATION > ql/src/test/results/clientnegative/default_constraint_invalid_type.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/default_constraint.q.out > PRE-CREATION > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h > f4a9c756e1 > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp > 921cba12b3 > > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp > b7326f05fc > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h > 835cbb3308 > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp > ef138e00bd > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AbortTxnsRequest.java > 0e5dbf7ae6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDefaultConstraintRequest.java > PRE-CREATION > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java > a01dc2463c > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddForeignKeyRequest.java > c1c0dbf229 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddNotNullConstraintRequest.java > 0bd85f3140 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java > 9119336a46 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java > 57d4953af6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPrimaryKeyRequest.java > 900985bb39 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddUniqueConstraintRequest.java > df4f54465c > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AllocateTableWriteIdsRequest.java > 1aec53bd4c > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AllocateTableWriteIdsResponse.java > e29e1db6b6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java > ee9841f650 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClientCapabilities.java > 8dbe4c1d44 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CompactionRequest.java > 1853720368 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreationMetadata.java > 717840fa0b > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DefaultConstraintsRequest.java > PRE-CREATION > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DefaultConstraintsResponse.java > PRE-CREATION > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java > b9dc04a317 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java > 8936410e23 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java > ca62b882c0 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java > ba29e90299 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java > 62b0768d10 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java > 881803fea0 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java > a051fb08b3 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java > 74ca66ae4f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java > ae644df9b3 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java > 662c093e4a > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesRequest.java > 84af22f413 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesResult.java > 4aba1d2153 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetValidWriteIdsRequest.java > ec738b0394 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetValidWriteIdsResponse.java > 50eba33a27 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java > 0bcd837235 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java > 85272ddc24 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java > cfdd0bdf76 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Materialization.java > c91b9cfea9 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java > 549c14b119 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java > ee7ae396f1 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRequest.java > 2283c24e0c > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesResponse.java > f551156768 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRow.java > 3f3c3b9e4d > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java > 3ccf5ee5cb > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java > 9941fa5603 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java > 8a0e5a5e79 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java > e4089c5f27 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java > d1b52476e4 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLDefaultConstraint.java > PRE-CREATION > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java > fb7b94e965 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java > 02dd278fa4 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java > 69be837ef9 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java > e65166ea0e > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java > 1d43fb84a3 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > adddd077ed > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java > 9c05a18123 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java > ba44e3ac21 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java > edec382d19 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java > 228f37f725 > > standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php > d063de853c > standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php a6047bf7b3 > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > b3a0524fa2 > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > dfddd4a7c9 > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 0c60aff5aa > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb > 625baae566 > standalone-metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb > 167bda29ac > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c6e34a8a22 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 14ba4ea0a2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 43aeeb3212 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 46412b0e9b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 7b44df4128 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > f500d63725 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 0d132f2074 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MConstraint.java > 865a9eed87 > standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql > 9d8a703b33 > standalone-metastore/src/main/sql/derby/upgrade-2.3.0-to-3.0.0.derby.sql > a50c45d4a0 > standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql > 1b7d0da1cc > standalone-metastore/src/main/sql/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql > 8ab466d5e7 > standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql > 886c93262b > standalone-metastore/src/main/sql/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql > a5377342aa > standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql > 366b2d90a0 > standalone-metastore/src/main/sql/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql > bd786fb03d > standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql > 4abf24c96b > > standalone-metastore/src/main/sql/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql > 34ed9742fa > standalone-metastore/src/main/thrift/hive_metastore.thrift b11ee380b4 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 75ea8c4a77 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 207d842f94 > > > Diff: https://reviews.apache.org/r/65778/diff/1/ > > > Testing > ------- > > * Added new tests > > > Thanks, > > Vineet Garg > >
