----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66121/#review199340 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java Line 152 (original), 152 (patched) <https://reviews.apache.org/r/66121/#comment279649> nit: if jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java Lines 165 (patched) <https://reviews.apache.org/r/66121/#comment279656> should the total wait time be configurable? jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java Lines 188 (patched) <https://reviews.apache.org/r/66121/#comment279655> warn? - Sergey Shelukhin On March 16, 2018, 6:59 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66121/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 6:59 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-18633 > https://issues.apache.org/jira/browse/HIVE-18633 > > > Repository: hive-git > > > Description > ------- > > HIVE-18633: Service discovery for Active/Passive HA mode > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java > 26acbd77b39d493bca9380df3e1ed2456d06dde4 > itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > 997726ca4bbdec4c2021ebfbd24870300e5e2669 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java > c3f9c63abd910f41578fcfc0199b6296e496940e > jdbc/src/java/org/apache/hive/jdbc/Utils.java > 9a129770b2cdcc0ed876fd985932bf46dbdb6266 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java > bc91f0cf5fd8eb2433e7ae9240ce56fccf5eac5b > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > e7227a87adf3b198b61aab5ce3be250341813d3d > > service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java > 6514d98d199efef1f4a894ce4c9ae8901a0e8040 > > service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistryClient.java > 512d4e83174bac2f0281740b396ed91bb9c1674b > service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java > 921a23e9cf066943530066434715032281ce7ced > > > Diff: https://reviews.apache.org/r/66121/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
