----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review199444 -----------------------------------------------------------
Ship it! +1, let's get this in. We can open new tickets for any remaining review Alexander has. - Daniel Dai On March 9, 2018, 9 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65634/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 9 p.m.) > > > Review request for hive, Alexander Kolbasov, Daniel Dai, and Thejas Nair. > > > Bugs: HIVE-18264 > https://issues.apache.org/jira/browse/HIVE-18264 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-18264 > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > a3725c5395 > service/src/java/org/apache/hive/service/server/HiveServer2.java 86c9c2b33c > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ac71d0882f > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 7b44df4128 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > f500d63725 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java > f0f650ddcf > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 0d132f2074 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java > 32ea17495f > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 50f873a013 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 75ea8c4a77 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 207d842f94 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java > ab6feb6f0b > standalone-metastore/src/test/resources/log4j2.properties 365687e1c9 > > > Diff: https://reviews.apache.org/r/65634/diff/5/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >