> On March 20, 2018, 6:59 p.m., Sergey Shelukhin wrote: > > service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java > > Lines 46 (patched) > > <https://reviews.apache.org/r/66127/diff/2/?file=1982536#file1982536line46> > > > > hmm... some testing will be needed for this, esp for security. Is it > > practical to do in unit tests?
Added unit tests in the new patch. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66127/#review199567 ----------------------------------------------------------- On March 21, 2018, 7:31 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66127/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 7:31 a.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-18982 > https://issues.apache.org/jira/browse/HIVE-18982 > > > Repository: hive-git > > > Description > ------- > > HIVE-18982: Provide a CLI option to manually trigger failover > > > Diffs > ----- > > bin/ext/hiveserver2.sh 1e94542 > common/src/java/org/apache/hive/http/HttpServer.java 71b2668 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java > 72b2a8c > itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java e1c2dd0 > > service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java > 7c75489 > service/src/java/org/apache/hive/service/server/HiveServer2.java bb92c44 > service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java > 33529ed > service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb > service/src/test/org/apache/hive/service/server/TestHS2HttpServerPam.java > d1b3ce0 > > > Diff: https://reviews.apache.org/r/66127/diff/3/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
