----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66188/#review199751 -----------------------------------------------------------
Hi Aihua, One small nit, and a question from here. Thanks, Peter standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 154-158 (original), 154-158 (patched) <https://reviews.apache.org/r/66188/#comment280197> It might be a good idea, to use this around our batching as well: - DatabaseProduct.needsInBatching(dbType) What do you think @Aihua? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Lines 842 (patched) <https://reviews.apache.org/r/66188/#comment280196> nit: typo: "queris" - Peter Vary On March 21, 2018, 6:57 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66188/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 6:57 p.m.) > > > Review request for hive, Alexander Kolbasov and Yongzhi Chen. > > > Repository: hive-git > > > Description > ------- > > If the table contains a lot of columns e.g, 5k, simple table rename would > fail with the following stack trace. The issue is datanucleus can't handle > the query with lots of colName='c1' && colName='c2' && ... . > > I'm breaking the query into multiple smaller queries and then we aggregate > the result together. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/alter_rename_table.q 2061850540 > ql/src/test/results/clientpositive/alter_rename_table.q.out 732d8a28d8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Batchable.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 6ead20aeaf > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 88d88ed4df > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 9f822564bd > > > Diff: https://reviews.apache.org/r/66188/diff/2/ > > > Testing > ------- > > Manual test has been done for large column of tables. > > > Thanks, > > Aihua Xu > >
