----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66222/#review199821 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java Lines 277 (patched) <https://reviews.apache.org/r/66222/#comment280296> Guava has compat issues specifically for StopWatch - System.nanoTime is likely to be better than the StopWatch - Gopal V On March 22, 2018, 6:08 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66222/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 6:08 p.m.) > > > Review request for hive and Gopal V. > > > Repository: hive-git > > > Description > ------- > > Add the following metrics related to the results cache: > public static final String QC_MAX_SIZE = "qc_max_size"; > public static final String QC_CURRENT_SIZE = "qc_current_size"; > public static final String QC_VALID_ENTRIES = "qc_valid_entries"; > public static final String QC_LOOKUPS = "qc_lookups"; > public static final String QC_VALID_HITS = "qc_valid_hits"; > public static final String QC_PENDING_HITS = "qc_pending_hits"; > public static final String QC_PENDING_FAILS = "qc_pending_fails"; > public static final String QC_PENDING_FAILS_WAIT_TIME = > "qc_pending_fails_wait_time"; > public static final String QC_PENDING_SUCCESS_WAIT_TIME = > "qc_pending_success_wait_time"; > // Queries rejected from being cached due to non-deterministic functions, > temp tables, or other conditions. > public static final String QC_INVALID_FOR_CACHING = > "qc_invalid_for_caching"; > // Queries rejected from being cached because they exceeded the max cache > entry size. > public static final String QC_REJECTED_TOO_LARGE = "qc_rejected_too_large"; > public static final String QC_TOTAL_ENTRIES_ADDED = > "qc_total_entries_added"; > > > Diffs > ----- > > > common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java > ecf27ceabe > ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java > 4fa1044232 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 36f6bcd069 > > > Diff: https://reviews.apache.org/r/66222/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
