----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66312/#review200050 -----------------------------------------------------------
Ship it! Ship It! - Peter Vary On March 27, 2018, 3:34 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66312/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 3:34 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-19060 > https://issues.apache.org/jira/browse/HIVE-19060 > > > Repository: hive-git > > > Description > ------- > > In the pre-commit jobs the > TestAppendPartitions.testAppendPartitionNullPartValues test is failing. > > It can be reproduced locally and the test is failing because it expected a > NPE to be thrown, but actually a NPE wrapped to a MetaException is thrown. > > Added a null check for the partition values and throw a MetaException if the > partition values list is null. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 519e8fe > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java > b67f33d > > > Diff: https://reviews.apache.org/r/66312/diff/1/ > > > Testing > ------- > > > Thanks, > > Marta Kuczora > >
