Adam Kennedy created HIVE-19082:
-----------------------------------
Summary: HiveLexer.allowQuotedId defaults incorrectly in the
absence of hiveConf
Key: HIVE-19082
URL: https://issues.apache.org/jira/browse/HIVE-19082
Project: Hive
Issue Type: Improvement
Components: Parser
Affects Versions: 2.3.2, 2.3.1, 2.3.0, 2.2.0, 2.1.1, 2.1.0
Reporter: Adam Kennedy
In HIVE-13101 a default was applied to prevent a null pointer exception when
hiveConf is null due to ParseDriver.parse(command) being called without a
Context parameter for a SQL command containing quoted identifiers. For
example...
CREATE TABLE `foo` (`bar` STRING)
Unfortunately, this false default is the opposite behavior of what occurs when
a Configuration is provided that does not contain an explicit value for the
setting.
The default for HiveConf.ConfVars.HIVE_QUOTEDID_SUPPORT is "column", which then
returns true.
Instead of shortcutting explicitly to false, the method should take the value
from...
HiveConf.ConfVars.HIVE_QUOTEDID_SUPPORT.getDefaultValue()
...and then apply the !"none".equals(...) check as normal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
