BELUGA BEHR created HIVE-19106:
----------------------------------

             Summary: Hive ZooKeeper Locking - Throw and Log
                 Key: HIVE-19106
                 URL: https://issues.apache.org/jira/browse/HIVE-19106
             Project: Hive
          Issue Type: Improvement
          Components: Locking
    Affects Versions: 2.3.2, 3.0.0
            Reporter: BELUGA BEHR


{code:java}
...
      } catch (Exception e) {
        if (tryNum >= numRetriesForUnLock) {
          String name = ((ZooKeeperHiveLock)hiveLock).getPath();
          LOG.error("Node " + name + " can not be deleted after " + 
numRetriesForUnLock + " attempts.");
          throw new LockException(e);
        }
      }
{code}

Do not log and throw.  Only throw and move the message into the 
{{LockException}}.  There is already {{error}} level logging up the stack.

https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java#L492-L495



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to