----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66397/#review200479 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 3052 (patched) <https://reviews.apache.org/r/66397/#comment281229> How complicated would it be to support all chars with backticks (in addition to "") as quote char. If we can, then we can switch default to standard as there won't be any back-compat issue. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java Lines 291 (patched) <https://reviews.apache.org/r/66397/#comment281232> It seems we are triple quoting now. Is that needed? ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g Line 35 (original), 45 (patched) <https://reviews.apache.org/r/66397/#comment281234> This should return default. HiveConf.getVar(ConfVar) ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g Line 526 (original), 545 (patched) <https://reviews.apache.org/r/66397/#comment281235> Would it be better that we replace backticks with "". That way parser supports both but later we only ever deal with "" ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 4246-4247 (original), 4246-4247 (patched) <https://reviews.apache.org/r/66397/#comment281236> This should be if ( "none".equals(qIdSupport)) { return true; } ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q Lines 60 (patched) <https://reviews.apache.org/r/66397/#comment281238> This query now collects both stats. So, prev query is not needed. ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q Lines 82-90 (patched) <https://reviews.apache.org/r/66397/#comment281237> Explain here should suffice for this tests. No need to actually execute queries. ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q Lines 94-100 (patched) <https://reviews.apache.org/r/66397/#comment281239> Also many of these queries are slight variations of other. We shall keep only handful of them. Adding so many new queries is not that useful and will strain our test infra. ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q Lines 113-121 (patched) <https://reviews.apache.org/r/66397/#comment281240> Also move them to only minillaplocal - Ashutosh Chauhan On April 3, 2018, 1:26 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66397/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 1:26 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-19064 > https://issues.apache.org/jira/browse/HIVE-19064 > > > Repository: hive-git > > > Description > ------- > > HIVE-19064 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 02367eb433ab9820b82f7a07f72eb0f503854716 > itests/src/test/resources/testconfiguration.properties > ec257139063c43ba90bb9853a92abace4896998d > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 429c296dee41e11e919d541c6510a9934572b29b > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java > 06adc647277a9b053cb509b14016f19dd578557b > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java > 1395027159f891d334a71b2d19d079ebaaaa573f > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java > 9057bb94b0b50e1ba693506b2d33d3ac8bb5c05c > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java > 286a47f15059d7eaf76c0c9fab8daaeca1769e0c > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java > dae18fb9b14d781904e8fec1b115e6a6eb7d7398 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > fe26283bd27d20890faeccdade1e24bd55f45fa2 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 2780be2518a78bce8d281d783bf3c06163685dda > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > 3ff6a5e4e30b30c9ba64b8f0a96714cd7e55954c > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 8b639f792226b817220d2b5eaefa62d41162a0b9 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 99e2c72d212cfaefe463b1fa32239d6b63aa9228 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > 8c238871765b0d5312a459a0e7f68c81f3837c13 > ql/src/test/queries/clientpositive/quotedid_basic_standard.q PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q > adc23e99b335f95552e16e1a0234a41e48aec18c > ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q > PRE-CREATION > ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_2.q > PRE-CREATION > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out > 31c97b0c6f6b66d7a3548b0bc68f51b203620e94 > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/quotedid_basic_standard.q.out > PRE-CREATION > ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out > 7a9cc12dbb66bb6d87c68c614b43189b8920a0c2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8539fea42fa2743381833ab3137579caeac64672 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java > 88cbfcdc4bc09fcc8be96c02521c7afb04736eca > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 995137f9675cd34b7d7c6f79bb78e206a65d99f7 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 8ea605169203d05bb9980babc43b8bd0799b51f1 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > 24e3c5667add1152a3e85f77d8b24727b46f2b8e > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > 9857c4ea673a6291aa77b61075646961c57e0aea > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > fe2d7587f6254e1698af42ce99fcd29443efffc3 > > > Diff: https://reviews.apache.org/r/66397/diff/2/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
