> On April 9, 2018, 10:23 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Line 14642 (original), 14643 (patched) > > <https://reviews.apache.org/r/66516/diff/1/?file=1994429#file1994429line14643> > > > > Does the loop only exit if cacheEntry is non-null?
The loop is a do .. while(false), which normally should exit after a single iteration. The loop should only continue to iterate in the event that cacheEntry.waitForValidStatus() returned false. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66516/#review200772 ----------------------------------------------------------- On April 9, 2018, 9:53 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66516/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 9:53 p.m.) > > > Review request for hive, Deepak Jaiswal and Gopal V. > > > Repository: hive-git > > > Description > ------- > > If the pending query fails, allow Hive to try to check the cache again in > case the cache has another cached/pending result that can be used to answer > the query. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 3b74abacf3 > > > Diff: https://reviews.apache.org/r/66516/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
